kustomize lookup plugin: build_flags #273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting a string of optional build_flags at the end of the command.
|
@eb4x Thanks for taking the time to contribute to this repo. |
abikouo
requested changes
Nov 16, 2021
There was a problem hiding this comment.
changelog required
update molecule tests https://github.com/ansible-collections/kubernetes.core/blob/main/molecule/default/tasks/lookup_kustomize.yml
Akasurde
suggested changes
Nov 17, 2021
| @@ -30,6 +30,9 @@ | |||
| opt_dirs: | |||
| description: | |||
| - An optional list of directories to search for the executable in addition to PATH. | |||
| build_flags: | |||
| description: | |||
| - Set additional build flags, like --enable-alpha-plugins | |||
There was a problem hiding this comment.
Suggested change
| - Set additional build flags, like --enable-alpha-plugins | |
| - Set additional build flags, like C(--enable-alpha-plugins). |
| @@ -136,6 +139,9 @@ def run( | |||
| ) | |||
| ) | |||
|
|
|||
| if "build_flags" in kwargs: | |||
There was a problem hiding this comment.
Please create a changelog fragment. See this fragment as an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting a string of optional build_flags at the end of the
command.
SUMMARY
A string to add some params/options to the end of "kustomize build dir" / "kubectl kustomize dir" command.
This could have been a list, or some other grandiose parsing event, I haven't put much thought into other use-cases.
ISSUE TYPE
COMPONENT NAME
kustomize lookup plugin
ADDITIONAL INFORMATION
It feels like a one-off kind of thing, where I just need to add "--enable-alpha-plugins" at the end. Maybe someone else will end up in a similar predicament later down the line, and be relieved that they can just build_flags="--all-my great --build-options are-available --yay".