Skip to content

fix: change walletsListSource URL to scalable #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: change walletsListSource URL to scalable #1525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web3/src/ton/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Ant Design Web3 provides `@ant-design/web3-ton` to adapt to the TON ecosystem. I

The interface design of `@ant-design/web3-ton` refers to the [TON official documentation](https://docs.ton.org/) and `@tonconnect/sdk`. You can find more in-depth implementation details in the documentation. The RPC service (such as balance inquiry) uses [Tonconnect](http://toncenter.com), including the testnet and mainnet.

You can check the wallets supported by Ton in the [Wallet Interface](https://raw.githubusercontent.com/ton-blockchain/wallets-list/main/wallets-v2.json). Ant Design Web3 provides settings for some commonly used wallets, as follows:
You can check the wallets supported by Ton in the [Wallet Interface](https://whatever-zeta-two.vercel.app/wallets-v2.json). Ant Design Web3 provides settings for some commonly used wallets, as follows:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The new URL https://whatever-zeta-two.vercel.app/wallets-v2.json appears to be a temporary Vercel deployment endpoint, which is not suitable for production documentation. This change introduces several issues:

  • Security Risk: It points to an unofficial and untrusted source for the wallet list. A compromised endpoint could serve a malicious list, leading to phishing attacks.
  • Reliability: A temporary deployment URL is not stable and can be taken down at any time, leading to broken links.
  • Scalability: Contrary to the PR title, a personal Vercel deployment is not a scalable solution and is less reliable than the original GitHub source.

For a truly scalable and reliable solution, consider using a public CDN that mirrors GitHub content, like jsDelivr. The URL would be https://cdn.jsdelivr.net/gh/ton-blockchain/wallets-list@main/wallets-v2.json.

Furthermore, this change creates an inconsistency, as the walletsListSource default value in the table on line 47 of this file still points to the old GitHub URL.

Suggested change
You can check the wallets supported by Ton in the [Wallet Interface](https://whatever-zeta-two.vercel.app/wallets-v2.json). Ant Design Web3 provides settings for some commonly used wallets, as follows:
You can check the wallets supported by Ton in the [Wallet Interface](https://cdn.jsdelivr.net/gh/ton-blockchain/wallets-list@main/wallets-v2.json). Ant Design Web3 provides settings for some commonly used wallets, as follows:


- telegram-wallet
- Tonkeeper
Expand Down
2 changes: 1 addition & 1 deletion packages/web3/src/ton/index.zh-CN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Ant Design Web3 官方提供了 `@ant-design/web3-ton` 来适配 TON 生态，

`@ant-design/web3-ton` 的接口设计参考了 [TON 官方文档](https://docs.ton.org/mandarin/)和`@tonconnect/sdk`，你可以在文档中找到更加深层的实现原理。RPC 服务（比如说查询余额）采用的是 [Tonconnect](http://toncenter.com)，包括测试网以及主网。

Ton 支持的钱包可以在 [钱包接口](https://raw.githubusercontent.com/ton-blockchain/wallets-list/main/wallets-v2.json) 中查看，Ant Design Web3 提供了部分常用钱包的设置，如下：
Ton 支持的钱包可以在 [钱包接口](https://whatever-zeta-two.vercel.app/wallets-v2.json) 中查看，Ant Design Web3 提供了部分常用钱包的设置，如下：
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The new URL https://whatever-zeta-two.vercel.app/wallets-v2.json appears to be a temporary Vercel deployment endpoint, which is not suitable for production documentation. This change introduces several issues:

  • Security Risk: It points to an unofficial and untrusted source for the wallet list. A compromised endpoint could serve a malicious list, leading to phishing attacks.
  • Reliability: A temporary deployment URL is not stable and can be taken down at any time, leading to broken links.
  • Scalability: Contrary to the PR title, a personal Vercel deployment is not a scalable solution and is less reliable than the original GitHub source.

For a truly scalable and reliable solution, consider using a public CDN that mirrors GitHub content, like jsDelivr. The URL would be https://cdn.jsdelivr.net/gh/ton-blockchain/wallets-list@main/wallets-v2.json.

Furthermore, this change creates an inconsistency, as the walletsListSource default value in the table on line 47 of this file still points to the old GitHub URL.

Suggested change
Ton 支持的钱包可以在 [钱包接口](https://whatever-zeta-two.vercel.app/wallets-v2.json) 中查看，Ant Design Web3 提供了部分常用钱包的设置，如下：
Ton 支持的钱包可以在 [钱包接口](https://cdn.jsdelivr.net/gh/ton-blockchain/wallets-list@main/wallets-v2.json) 中查看，Ant Design Web3 提供了部分常用钱包的设置，如下：


- telegram-wallet
- Tonkeeper
Expand Down