Skip to content

Conversation

j3ttt
Copy link
Collaborator

@j3ttt j3ttt commented Sep 18, 2025

Thank you for your contribution to CloudRec!

What About:

  • Server (java)
  • Collector (go)
  • Rule (opa)

Description:

Bug Fixes:

  1. Fix resource type references for Inspector2 coverage and findings and for Network Firewall rule groups in service initialization and resource definitions.
  2. Include IAMPolicy in the IAM client initialization mapping.

Summary by Sourcery

Separate Inspector2 and Network Firewall resource types, introduce corresponding constants, and update service initialization and resource definitions to reference the correct AWS resource types.

New Features:

  • Introduce new constants Inspector2Coverage, Inspector2Finding, and NetworkFirewallRuleGroup for distinct resource types.

Bug Fixes:

  • Fix resource type references for Inspector2 coverage and findings and for Network Firewall rule groups in service initialization and resource definitions.
  • Include IAMPolicy in the IAM client initialization mapping.

Enhancements:

  • Update service case statements to leverage the new resource type constants for Inspector2 and NetworkFirewall.
  • Adjust resource definitions to reference the specific Inspector2Coverage, Inspector2Finding, and NetworkFirewallRuleGroup constants instead of generic types.

Copy link

Important

Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services.

Copy link

sourcery-ai bot commented Sep 18, 2025

Reviewer's Guide

Introduces specific ResourceType constants for Inspector2 coverage, Inspector2 finding, and Network Firewall rule group, and updates client initialization and resource definitions to reference these new constants instead of generic ones.

File-Level Changes

Change Details Files
Add new resource type constants for Inspector2 coverage, Inspector2 finding, and Network Firewall rule group
  • Define Inspector2Coverage constant
  • Define Inspector2Finding constant
  • Define NetworkFirewallRuleGroup constant
collector/aws/collector/constant.go
Extend service client initialization cases to use the new constants
  • Add IAMPolicy to IAM client cases
  • Split Inspector2 case into Inspector2Coverage and Inspector2Finding
  • Include NetworkFirewallRuleGroup in Network Firewall init case
collector/aws/collector/services.go
Update resource definitions to reference the correct ResourceType constants
  • Change coverage resource to use Inspector2Coverage
  • Change finding resource to use Inspector2Finding
  • Change rule group resource to use NetworkFirewallRuleGroup
collector/aws/collector/inspector2/coverage.go
collector/aws/collector/inspector2/finding.go
collector/aws/collector/networkfirewall/rulegroup.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@j3ttt j3ttt self-assigned this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant