Update memory region names #45
Conversation
LucasSte
force-pushed
the
change-naming
branch
2 times, most recently
from
a721452 to
0b1cdf8
Compare
LucasSte
changed the title
| pub const MM_STACK_START: u64 = MM_REGION_SIZE * 2; | ||
| /// Virtual address of the heap region | ||
| pub const MM_HEAP_START: u64 = MM_REGION_SIZE * 3; | ||
| /// Virtual address of the input region |
There was a problem hiding this comment.
shouldn't "Input" be renamed?
There was a problem hiding this comment.
I did not rename it, because it is still the same. Should it be called MM_TX_INPUT_START?
There was a problem hiding this comment.
"Input" is kinda a useless name because it does not say from where to where, it is subjective depending on the perspective, like "left" and "right". Maybe MM_TX_AREA, MM_TX_INSTRUCTION_AREA and MM_TX_INSTRUCTION_DATA.
There was a problem hiding this comment.
Then again, we probably want multiple instructions mapped in at once. So MM_TX_INSTRUCTION_DATA might not cut it either.
There was a problem hiding this comment.
Then again, we probably want multiple instructions mapped in at once.
Even if we follow that path, the most important instruction for a program is the one being executed, so having that one in a predicted address that can be read without any other dependencies is preferable. The SDK could then access other instructions on demand.
src/ebpf.rs
Outdated
| pub const MM_INPUT_START: u64 = MM_REGION_SIZE * 4; | ||
| pub const MM_TX_AREA: u64 = MM_REGION_SIZE * 4; | ||
| /// Virtual address of the scratch pad area | ||
| pub const MM_SCRATCHPAD_AREA: u64 = MM_REGION_SIZE * 5; |
There was a problem hiding this comment.
Just read the SIMD again, and I think I made a mistake calling this "scratchpad". We should stick with the current naming of this being "return-data".
There was a problem hiding this comment.
I updated all names according to the latest version of the SIMD in 8ba1d93
2 participants
Summary of changes