Refactor/instruction trace dump #72
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to respect the VM_TRACE_DIR variable and hence dump the instruction trace in the provided directory.
I've managed to wrap up a working setup with this code on top of
mollusk-svm 0.6.1
. I've only had to silence the lack of the trace method of the ContextObject trait by bringing a dummy back.Please have a look. I'm not pretty sure if this is the right place for the
AsBytes
trait. I'm also unsure about the possibility of passing an error back if writing of the files fails due to some reason.