Skip to content

(typing) Allow readonly array of wallets for WalletProvider #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(typing) Allow readonly array of wallets for WalletProvider #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/react/src/WalletProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { WalletProviderBase } from './WalletProviderBase.js';

export interface WalletProviderProps {
children: ReactNode;
wallets: Adapter[];
wallets: readonly Adapter[];
autoConnect?: boolean | ((adapter: Adapter) => Promise<boolean>);
localStorageKey?: string;
onError?: (error: WalletError, adapter?: Adapter) => void;
Expand Down Expand Up @@ -49,7 +49,7 @@ export function WalletProvider({
onError,
}: WalletProviderProps) {
const { connection } = useConnection();
const adaptersWithStandardAdapters = useStandardWalletAdapters(adapters);
const adaptersWithStandardAdapters = useStandardWalletAdapters(adapters as Adapter[]);
Copy link
Author

@dearlordylord dearlordylord Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would require same improvement for useStandardWalletAdapters of @solana/wallet-standard-wallet-adapter-react

const mobileWalletAdapter = useMemo(() => {
if (!getIsMobile(adaptersWithStandardAdapters)) {
return null;
Expand Down