Skip to content

[C++][Benchmarks] Experiment with CMAKE_INTERPROCEDURAL_OPTIMIZATION #47637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[C++][Benchmarks] Experiment with CMAKE_INTERPROCEDURAL_OPTIMIZATION #47637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bb8bb1
[C++][Benchmarks] Experiment with CMAKE_INTERPROCEDURAL_OPTIMIZATION
pitrou Sep 24, 2025
bf2698a
Add binutils
pitrou Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/scripts/cpp_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ else
-DCMAKE_C_FLAGS="${CFLAGS:-}" \
-DCMAKE_CXX_FLAGS="${CXXFLAGS:-}" \
-DCMAKE_CXX_STANDARD="${CMAKE_CXX_STANDARD:-17}" \
-DCMAKE_INTERPROCEDURAL_OPTIMIZATION="${CMAKE_INTERPROCEDURAL_OPTIMIZATION:-OFF}" \
-DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR:-lib} \
-DCMAKE_INSTALL_PREFIX=${CMAKE_INSTALL_PREFIX:-${ARROW_HOME}} \
-DCMAKE_UNITY_BUILD=${CMAKE_UNITY_BUILD:-OFF} \
Expand Down
1 change: 1 addition & 0 deletions dev/conbench_envs/benchmarks.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ ARROW_WITH_LZ4=ON
ARROW_WITH_SNAPPY=ON
ARROW_WITH_ZLIB=ON
ARROW_WITH_ZSTD=ON
CMAKE_INTERPROCEDURAL_OPTIMIZATION=ON
GTest_SOURCE=BUNDLED
ORC_SOURCE=BUNDLED
PARQUET_BUILD_EXAMPLES=ON
Expand Down
29 changes: 13 additions & 16 deletions dev/conbench_envs/hooks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,22 @@
# specific language governing permissions and limitations
# under the License.

set -ex

## These hooks are used by benchmark builds
# to create a conda env with Arrow dependencies and build Arrow C++, Python, etc
create_conda_env_for_benchmark_build() {
conda create -y -n "${BENCHMARKABLE_TYPE}" -c conda-forge \
--file ci/conda_env_unix.txt \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_python.txt \
--file ci/conda_env_gandiva.txt \
compilers \
python="${PYTHON_VERSION}" \
pandas \
aws-sdk-cpp \
r
conda create -q -y -n "${BENCHMARKABLE_TYPE}" -c conda-forge --override-channels \
--file ci/conda_env_unix.txt \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_python.txt \
--file ci/conda_env_gandiva.txt \
binutils \
compilers \
python="${PYTHON_VERSION}" \
pandas \
aws-sdk-cpp \
r
}

activate_conda_env_for_benchmark_build() {
Expand All @@ -50,12 +52,7 @@ set_arrow_build_and_run_env_vars() {

build_arrow_cpp() {
export ARROW_BUILD_DIR="/tmp/$(uuidgen)"
# Ignore the error when a cache can't be created
if ! ci/scripts/cpp_build.sh $(pwd) $ARROW_BUILD_DIR 2> error.log; then
if ! grep -q -F "Can\'t create temporary cache file" error.log; then
cat error.log
fi
fi
ci/scripts/cpp_build.sh $(pwd) $ARROW_BUILD_DIR
}

build_arrow_python() {
Expand Down
Loading