GH-47664: [C++][Parquet] add num_rows_ before each call to RowGroupWriter::Close in FileSerializer #47665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting review
Contributor
Author
mapleFU
approved these changes
Sep 28, 2025
github-actions
bot
added
awaiting committer review
wgtmac
approved these changes
Sep 28, 2025
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5750e29. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Oct 15, 2025
…roupWriter::Close in FileSerializer (apache#47665) ### Rationale for this change Fix wrong result of `num_rows()` method in `FileSerializer`. ### What changes are included in this PR? 1. add `num_rows_` before each call to `RowGroupWriter::Close` in `FileSerializer`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Now `num_rows_` will return the corrent result which is the number of rows in the yet started RowGroups. * GitHub Issue: apache#47664 Authored-by: Zehua Zou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix wrong result of
num_rows()method inFileSerializer.What changes are included in this PR?
num_rows_before each call toRowGroupWriter::CloseinFileSerializer.Are these changes tested?
Yes.
Are there any user-facing changes?
Now
num_rows_will return the corrent result which is the number of rows in the yet started RowGroups.num_rowsmethod inFileSerializerreturns wrong number. #47664