PR #11778 with changes for main branch #11781

rohityadavcloud · 2025-10-03T06:12:34Z

This continues PR #11778, but for main branch with 4.22 specific changes.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

This bumps the systemvmtemplate version to 4.22 for use with the main/4.22 branch. Signed-off-by: Rohit Yadav <[email protected]>

rohityadavcloud · 2025-10-03T06:16:41Z

I've used @weizhouapache 's PR to add some custom changes -- but we could in theory just use the 4.20.2.0 template for main/4.22, I don't notice huge difference b/w 4.20 & main for systemvmtemplate use -- please advise @harikrishna-patnala @weizhouapache

Kicked build job for this PR, if/when successful (in 1-2 hrs+) the templates will be avaliable here: https://build.yadav.cloud/systemvm/

codecov · 2025-10-03T06:21:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.50%. Comparing base (b09f3e8) to head (b265530).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11781      +/-   ##
============================================
- Coverage     17.50%   17.50%   -0.01%     
- Complexity    15427    15428       +1     
============================================
  Files          5894     5894              
  Lines        526880   526880              
  Branches      64338    64338              
============================================
- Hits          92243    92242       -1     
  Misses       424260   424260              
- Partials      10377    10378       +1

Flag	Coverage Δ
uitests	`3.61% <ø> (ø)`
unittests	`18.56% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache · 2025-10-03T07:07:43Z

I've used @weizhouapache 's PR to add some custom changes -- but we could in theory just use the 4.20.2.0 template for main/4.22, I don't notice huge difference b/w 4.20 & main for systemvmtemplate use -- please advise @harikrishna-patnala @weizhouapache

Kicked build job for this PR, if/when successful (in 1-2 hrs+) the templates will be avaliable here: https://build.yadav.cloud/systemvm/

thanks @rohityadavcloud

we do need to rebuild 4.22 system templates due to #11726

weizhouapache

lgtm

vishesh92

lgtm

harikrishna-patnala · 2025-10-07T03:46:51Z

@blueorangutan package

blueorangutan · 2025-10-07T03:48:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-07T04:29:42Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 15309

harikrishna-patnala · 2025-10-07T10:49:09Z

@blueorangutan test matrix

blueorangutan · 2025-10-07T10:50:04Z

@harikrishna-patnala a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-10-07T11:49:04Z

[SF] Trillian Build Failed (tid-14558)

blueorangutan · 2025-10-07T11:57:08Z

[SF] Trillian Build Failed (tid-14557)

blueorangutan · 2025-10-07T12:01:12Z

[SF] Trillian Build Failed (tid-14555)

harikrishna-patnala · 2025-10-09T07:46:22Z

@blueorangutan test

blueorangutan · 2025-10-09T07:48:05Z

@harikrishna-patnala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-10-09T08:57:56Z

[SF] Trillian Build Failed (tid-14597)

rohityadavcloud · 2025-10-10T04:08:00Z

Do we need manual building of the packages? And should we upload the 4.22/main systemvmtemplates/files on download.cloudstack.org @weizhouapache @harikrishna-patnala ?

weizhouapache · 2025-10-10T07:00:13Z

@blueorangutan package

blueorangutan · 2025-10-10T07:02:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

harikrishna-patnala · 2025-10-10T07:19:22Z

Do we need manual building of the packages? And should we upload the 4.22/main systemvmtemplates/files on download.cloudstack.org @weizhouapache @harikrishna-patnala ?

@rohityadavcloud Wei has copied the recently built templates for 4.22 internally. So the tests should run now. Once we get the good results, we can merge this PR and then move the templates to download.cloudstack.org.

Does this sound good @weizhouapache @rohityadavcloud ?

weizhouapache · 2025-10-10T07:57:39Z

Do we need manual building of the packages? And should we upload the 4.22/main systemvmtemplates/files on download.cloudstack.org @weizhouapache @harikrishna-patnala ?

@rohityadavcloud Wei has copied the recently built templates for 4.22 internally. So the tests should run now. Once we get the good results, we can merge this PR and then move the templates to download.cloudstack.org.

Does this sound good @weizhouapache @rohityadavcloud ?

@harikrishna-patnala
yes, looks good !

blueorangutan · 2025-10-10T08:45:12Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15390

harikrishna-patnala · 2025-10-10T08:53:10Z

@blueorangutan test matrix

blueorangutan · 2025-10-10T08:54:04Z

@harikrishna-patnala a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

blueorangutan · 2025-10-10T09:16:02Z

[SF] Trillian Build Failed (tid-14614)

blueorangutan · 2025-10-11T04:35:30Z

[SF] Trillian test result (tid-14617)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 64350 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11781-t14617-kvm-ubuntu22.zip
Smoke tests completed. 147 look OK, 1 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	269.72	test_routers_network_ops.py
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py

blueorangutan · 2025-10-11T04:54:12Z

[SF] Trillian test result (tid-14615)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 67871 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11781-t14615-vmware-70u3.zip
Smoke tests completed. 146 look OK, 2 have errors, 1 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_enableHumanReadableLogs	`Error`	0.26	test_human_readable_logs.py
test_01_vpn_usage	`Error`	1.18	test_usage.py
all_test_image_store_object_migration	`Skipped`	---	test_image_store_object_migration.py

blueorangutan · 2025-10-11T13:50:55Z

[SF] Trillian test result (tid-14616)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 100794 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11781-t14616-xcpng82.zip
Smoke tests completed. 142 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_enableHumanReadableLogs	`Error`	0.26	test_human_readable_logs.py
test_01_non_strict_host_anti_affinity	`Error`	234.03	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	`Error`	74.92	test_nonstrict_affinity_group.py
test_01_primary_storage_iscsi	`Error`	0.91	test_primary_storage.py
test_02_list_snapshots_with_removed_data_store	`Error`	15.01	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	15.02	test_snapshots.py
test_01_volume_usage	`Failure`	102.91	test_usage.py
test_01_vpn_usage	`Error`	1.16	test_usage.py
test_11_destroy_vm_and_volumes	`Error`	29.46	test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success	`Error`	67.92	test_vm_strict_host_tags.py

harikrishna-patnala · 2025-10-13T09:39:17Z

These tests are failing on health check PR as well.

* systemvmtemplate: Bump Debian version to 12.12.0 * systemvmtemplate: bump version to 4.22 This bumps the systemvmtemplate version to 4.22 for use with the main/4.22 branch. Signed-off-by: Rohit Yadav <[email protected]> --------- Signed-off-by: Rohit Yadav <[email protected]> Co-authored-by: Wei Zhou <[email protected]>

weizhouapache and others added 2 commits October 3, 2025 11:40

systemvmtemplate: Bump Debian version to 12.12.0

3d10f67

systemvmtemplate: bump version to 4.22

b265530

This bumps the systemvmtemplate version to 4.22 for use with the main/4.22 branch. Signed-off-by: Rohit Yadav <[email protected]>

boring-cyborg bot added component:build component:templates systemvm-template-change labels Oct 3, 2025

rohityadavcloud requested review from harikrishna-patnala and weizhouapache October 3, 2025 06:12

rohityadavcloud added this to the 4.22.0 milestone Oct 3, 2025

weizhouapache approved these changes Oct 3, 2025

View reviewed changes

vishesh92 approved these changes Oct 3, 2025

View reviewed changes

harikrishna-patnala added this to Apache CloudStack 4.22.0 Oct 7, 2025

harikrishna-patnala moved this to In Progress in Apache CloudStack 4.22.0 Oct 7, 2025

harikrishna-patnala merged commit 8464e46 into apache:main Oct 13, 2025
27 checks passed

harikrishna-patnala deleted the systmpl-422 branch October 13, 2025 09:39

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Oct 13, 2025

PR #11778 with changes for main branch #11781

PR #11778 with changes for main branch #11781

Uh oh!

Conversation

rohityadavcloud commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

rohityadavcloud commented Oct 3, 2025

Uh oh!

codecov bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Oct 3, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

harikrishna-patnala commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

blueorangutan commented Oct 7, 2025

Uh oh!

harikrishna-patnala commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

blueorangutan commented Oct 9, 2025

Uh oh!

rohityadavcloud commented Oct 10, 2025

Uh oh!

weizhouapache commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

harikrishna-patnala commented Oct 10, 2025

Uh oh!

weizhouapache commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

harikrishna-patnala commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

blueorangutan commented Oct 11, 2025

Uh oh!

harikrishna-patnala commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

rohityadavcloud commented Oct 3, 2025 •

edited

Loading

codecov bot commented Oct 3, 2025 •

edited

Loading