[LANG-1597][LANG-1782] Fix getMatchingAccessibleMethod when no varargs are supplied and when the supplied varargs don't match the exact class #1427
+211
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are supplied and when the supplied varargs don't match the exact class The current implementation discarded methods which could be potential matches because the matching was way to strict. This change loosens the check to allow any assignable values. The change also checks all variable arguments instead of just the last argument. To facilitate various number types and conversion NumberUtils.convertIfNotNarrowing was also introduced. This allows integers to be passed to methods which take Long... varargs
joeferner
force-pushed
the
LANG-1782-fix
branch
from
16190be to
6ac0dea
Compare
garydgregory
requested changes
Aug 23, 2025
There was a problem hiding this comment.
Hello @joeferner
Thank you for your updates. Please rebase on git master and see my comments.
| * value</li> | ||
| * </ul> | ||
| */ | ||
| public static <T extends Number> T convertIfNotNarrowing(Number number, Class<T> targetType) { |
There was a problem hiding this comment.
Let's keep all of this package-private in the .reflect package.
| } | ||
|
|
||
| // Perform conversion | ||
| if (targetType == Byte.class) { |
There was a problem hiding this comment.
What about char primitives?
| /** | ||
| * Returns a numeric rank for the specified number type to determine | ||
| * its position in the widening conversion hierarchy. | ||
| * <p> |
There was a problem hiding this comment.
You'll want to link to the JLS to show canonical definitions.
| @@ -994,6 +1012,16 @@ void testInvokeJavaVarargsOverloadingResolution() throws Exception { | |||
| (Object[]) ArrayUtils.EMPTY_CLASS_ARRAY)); | |||
| } | |||
|
|
|||
| @Test | |||
| void testInvokeJavaVarargsResolution() throws Exception { | |||
There was a problem hiding this comment.
Does this cover all of the getRank() cases?
What about char?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LANG-1597 and LANG-1782
The current implementation discarded methods which could be potential matches because the matching was way to strict. This change loosens the check to allow any assignable values. The change also checks all variable arguments instead of just the last argument.
To facilitate various number types and conversion
NumberUtils.convertIfNotNarrowing was also introduced. This allows integers to be passed to methods which take Long... varargs