Skip to content

Capture error message, otherwise capture cause of HTTP failure #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 15, 2025
Merged

Capture error message, otherwise capture cause of HTTP failure #358

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b971926
Capture error message, otherwise capture cause of HTTP failure
digitalextremist Sep 14, 2025
1537ad8
Comment to clarify what 'response' might be
digitalextremist Sep 15, 2025
d3da6c5
Improvement of performance, readability, and priority in failure case
digitalextremist Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions lib/nano.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,16 +122,18 @@ module.exports = exports = function dbScope (cfg) {
}
}

// let parsed
const responseHeaders = Object.assign({
const responseHeaders = {
uri: scrubURL(req.url),
statusCode
}, response.headers ? response.headers : {})
statusCode,
...(response.headers ?? {})
};

if (!response.status) {
response.statusText = response.cause.toString()
log({ err: 'socket', body, headers: responseHeaders })
if (reject) {
reject(new Error(`error happened in your connection. Reason: ${response.statusText}`))
// since #relax might have sent Error rather than Response:
const statusText = response.cause?.toString() ?? response.message
reject(new Error(`error happened in your connection. Reason: ${statusText}`))
}
return
}
Expand Down