WIP: Upgrade to arrow 56.1.0 #17275
Draft
WIP: Upgrade to arrow 56.1.0 #17275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sqllogictest
5 tasks
alamb
commented
Aug 21, 2025
| +-----------------------------------+-----------------+---------------------+------+------------------+ | ||
| | filename | file_size_bytes | metadata_size_bytes | hits | extra | | ||
| +-----------------------------------+-----------------+---------------------+------+------------------+ | ||
| | alltypes_plain.parquet | 1851 | 10181 | 2 | page_index=false | | ||
| | alltypes_tiny_pages.parquet | 454233 | 881634 | 2 | page_index=true | | ||
| | alltypes_tiny_pages.parquet | 454233 | 881418 | 2 | page_index=true | |
There was a problem hiding this comment.
I don't really know why the in-memory size of the ParquetMetadata has decreased, but it seems like a good improvement to me
| @@ -535,8 +535,8 @@ async fn load_page_index<T: AsyncFileReader>( | |||
| if missing_column_index || missing_offset_index { | |||
| let m = Arc::try_unwrap(Arc::clone(parquet_metadata)) | |||
| .unwrap_or_else(|e| e.as_ref().clone()); | |||
| let mut reader = | |||
| ParquetMetaDataReader::new_with_metadata(m).with_page_indexes(true); | |||
| let mut reader = ParquetMetaDataReader::new_with_metadata(m) | |||
There was a problem hiding this comment.
Due to this change from @kczimm
| datafusion-spark = { path = "datafusion/spark", version = "49.0.0" } | ||
| datafusion-sql = { path = "datafusion/sql", version = "49.0.0" } | ||
| datafusion-substrait = { path = "datafusion/substrait", version = "49.0.0" } | ||
| datafusion = { path = "datafusion/core", version = "49.0.1", default-features = false } |
There was a problem hiding this comment.
drive by change to update all versions in Cargo.toml to the latest
alamb
commented
Aug 21, 2025
| @@ -1314,7 +1314,7 @@ physical_plan | |||
| 11)┌─────────────┴─────────────┐┌─────────────┴─────────────┐ | |||
| 12)│ DataSourceExec ││ DataSourceExec │ | |||
| 13)│ -------------------- ││ -------------------- │ | |||
| 14)│ bytes: 6040 ││ bytes: 6040 │ | |||
| 14)│ bytes: 5932 ││ bytes: 5932 │ | |||
There was a problem hiding this comment.
I believe the in memory size may have improved due to
And the Vec doesn't have the same minimum alignment / size that the builders had
| @@ -724,7 +724,7 @@ mod tests { | |||
| .unwrap(); | |||
|
|
|||
| let size = get_record_batch_memory_size(&batch); | |||
| assert_eq!(size, 8320); | |||
| assert_eq!(size, 8208); | |||
There was a problem hiding this comment.
- Also due to Use
Vecdirectly in builders arrow-rs#7984
alamb
changed the title
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
|
🤖 |
|
🤖: Benchmark completed Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
56.1.0(August 2025) arrow-rs#7837Rationale for this change
Upgrade to the latest arrow release
What changes are included in this PR?
56.1.0release arrow-rs#8202)TODO:
Are these changes tested?
Functionally By CI
I will also run benchmarks against this branch
Are there any user-facing changes?