fix: dataframe function count_all with alias #17282
Merged
+54
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kosiew pls review |
|
LGTM. note: This is a re-implementation of #17253 |
kosiew
approved these changes
Aug 22, 2025
Comment on lines
1787
to
1796
| // Unwrap all alias layers to get to the underlying aggregate function | ||
| let (name, human_display, e) = match e { | ||
| Expr::Alias(Alias { expr, name, .. }) => { | ||
| (Some(name.clone()), String::default(), expr.as_ref()) | ||
| Expr::Alias(Alias { name, .. }) => { | ||
| let unaliased = e.clone().unalias_nested().data; | ||
| ( | ||
| Some(name.clone()), | ||
| e.human_display().to_string(), | ||
| unaliased.clone(), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Follow up action:
This is useful to be extracted to a helper function eg
Expr::unwrap_alias.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
count_all() aggregations cannot be aliased #16795
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?