Fix ambiguous column names in substrait conversion as a result of literals having the same name during conversion. #17299
+335
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
#17294
Rationale for this change
Fix ambiguous column names in substrait conversion as a result of literals before and after a join being assigned the same name.
More information in the issue, but say you have a
NULL
literal before a join called "column1" and then you create a newNULL
column after the join calledcolumn2
, you would get an ambiguous column name errors like.What changes are included in this PR?
Simply alias all literals as they're converted to have a UUID name.
Are these changes tested?
Yes.
Tested by using substrait-java with this query
Are there any user-facing changes?