Skip to content

branch-3.1: [fix](warmup) fix NPE in getTabletReplicaInfos #55130 #55199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: branch-3.1
Choose a base branch
from
Open

branch-3.1: [fix](warmup) fix NPE in getTabletReplicaInfos #55130 #55199

wants to merge 1 commit into from
+8 −0

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #55130

@kaijchen
[fix](warmup) fix NPE in getTabletReplicaInfos (#55130)
d951fe6 
Prevent NPE in `getClusterPrimaryBackendId` when `clusterName` is
invalid.
Previously this only resulted in noisy error logs without impacting
functionality.
@github-actions github-actions bot requested a review from morrySnow as a code owner August 22, 2025 12:49
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Aug 22, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32365 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d951fe6d3badf0038b05899a04843a55e548fa51, data reload: false

------ Round 1 ----------------------------------
q1	17614	5561	5446	5446
q2	2019	408	279	279
q3	12252	1215	737	737
q4	10300	879	456	456
q5	9253	2327	2112	2112
q6	179	158	132	132
q7	894	741	607	607
q8	9333	1389	1106	1106
q9	5233	4894	4937	4894
q10	6753	2243	1796	1796
q11	468	269	270	269
q12	327	357	220	220
q13	17762	3599	2984	2984
q14	217	223	213	213
q15	527	465	465	465
q16	433	424	362	362
q17	606	854	369	369
q18	6767	6394	6307	6307
q19	1199	949	544	544
q20	321	345	210	210
q21	2742	2129	1921	1921
q22	1031	1014	936	936
Total cold run time: 106230 ms
Total hot run time: 32365 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5518	5497	5481	5481
q2	232	320	240	240
q3	2249	2651	2330	2330
q4	1339	1770	1360	1360
q5	4338	4884	4899	4884
q6	173	167	127	127
q7	2033	1960	1780	1780
q8	2605	2819	2673	2673
q9	7285	7221	7214	7214
q10	3045	3329	2709	2709
q11	557	530	506	506
q12	693	823	667	667
q13	3497	3909	3330	3330
q14	294	311	284	284
q15	526	477	472	472
q16	459	509	448	448
q17	1255	1761	1254	1254
q18	7714	7378	7376	7376
q19	783	860	1141	860
q20	2037	2059	1908	1908
q21	5281	4860	4428	4428
q22	1069	1093	1055	1055
Total cold run time: 52982 ms
Total hot run time: 51386 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192180 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d951fe6d3badf0038b05899a04843a55e548fa51, data reload: false

query1	960	371	387	371
query2	6220	2000	1947	1947
query3	8713	200	197	197
query4	33560	24246	24009	24009
query5	4419	597	466	466
query6	294	196	172	172
query7	4222	473	308	308
query8	300	238	232	232
query9	9541	2595	2579	2579
query10	498	316	255	255
query11	18433	15760	15222	15222
query12	164	110	104	104
query13	1550	536	418	418
query14	9923	7320	6570	6570
query15	260	189	189	189
query16	7256	699	473	473
query17	1522	744	619	619
query18	2019	411	329	329
query19	224	190	168	168
query20	129	129	131	129
query21	207	133	113	113
query22	4476	4648	4370	4370
query23	35042	34013	33933	33933
query24	7394	2670	2679	2670
query25	544	491	424	424
query26	1067	283	177	177
query27	2263	486	363	363
query28	5319	2204	2174	2174
query29	724	600	458	458
query30	243	199	157	157
query31	1021	914	825	825
query32	97	62	58	58
query33	524	371	309	309
query34	752	850	529	529
query35	776	839	738	738
query36	1028	1059	955	955
query37	111	93	66	66
query38	3992	3983	3989	3983
query39	1515	1467	1485	1467
query40	211	126	104	104
query41	49	50	50	50
query42	123	110	105	105
query43	506	545	494	494
query44	1313	840	829	829
query45	184	178	172	172
query46	907	1055	675	675
query47	1981	1967	1922	1922
query48	401	420	347	347
query49	768	505	425	425
query50	674	701	417	417
query51	7435	7293	7299	7293
query52	99	101	96	96
query53	232	260	191	191
query54	551	566	482	482
query55	85	84	81	81
query56	257	274	255	255
query57	1280	1262	1225	1225
query58	231	212	224	212
query59	3104	3223	3187	3187
query60	294	291	271	271
query61	115	115	113	113
query62	799	752	692	692
query63	228	196	192	192
query64	4557	992	644	644
query65	3359	3328	3307	3307
query66	970	415	315	315
query67	16546	15857	15427	15427
query68	7568	808	532	532
query69	481	308	273	273
query70	1222	1152	1084	1084
query71	429	292	268	268
query72	5130	3733	3762	3733
query73	642	749	350	350
query74	10462	9154	9263	9154
query75	3915	3167	2676	2676
query76	3624	1172	767	767
query77	778	370	277	277
query78	10363	10299	9583	9583
query79	4601	884	602	602
query80	726	514	432	432
query81	496	259	223	223
query82	346	122	92	92
query83	170	166	144	144
query84	290	107	83	83
query85	745	349	296	296
query86	352	308	286	286
query87	4314	4278	4180	4180
query88	3548	2441	2397	2397
query89	436	326	296	296
query90	2105	193	190	190
query91	137	135	108	108
query92	71	54	52	52
query93	2618	866	535	535
query94	663	409	304	304
query95	344	275	268	268
query96	494	612	281	281
query97	3203	3260	3154	3154
query98	214	213	200	200
query99	1482	1430	1311	1311
Total cold run time: 296530 ms
Total hot run time: 192180 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.32 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d951fe6d3badf0038b05899a04843a55e548fa51, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.02	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.11
query5	0.53	0.50	0.52
query6	1.12	0.74	0.73
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.48
query10	0.56	0.55	0.55
query11	0.14	0.10	0.10
query12	0.13	0.11	0.11
query13	0.61	0.59	0.59
query14	0.78	0.79	0.79
query15	0.84	0.82	0.82
query16	0.38	0.38	0.40
query17	1.00	1.02	1.05
query18	0.24	0.21	0.24
query19	1.94	1.78	1.79
query20	0.02	0.01	0.01
query21	15.41	0.89	0.57
query22	0.73	0.75	0.56
query23	15.30	1.38	0.56
query24	3.33	1.25	0.71
query25	0.17	0.23	0.06
query26	0.26	0.14	0.14
query27	0.05	0.05	0.04
query28	13.29	1.07	0.41
query29	12.61	3.92	3.16
query30	0.26	0.09	0.07
query31	2.82	0.58	0.37
query32	3.22	0.53	0.46
query33	2.99	2.99	3.05
query34	16.64	5.21	4.56
query35	4.55	4.54	4.55
query36	0.63	0.51	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 103.6 s
Total hot run time: 28.32 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow Awaiting requested review from morrySnow morrySnow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hello-stephen @doris-robot @dataroaring @kaijchen