-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[refine](function) Remove unused code from the function framework and optimize the default NULL-handling logic. #57811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34429 ms |
TPC-DS: Total hot run time: 189436 ms |
ClickBench: Total hot run time: 27.73 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zclllyybb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… optimize the default NULL-handling logic. (apache#57811) There used to be many unused parameters in the function framework; this PR removes them. The previous default-NULL handling framework inserted intermediate results into the block and then erased them — when blocks are large this caused significant overhead. Now intermediates are handled using a temporary block, and a simple_insert function is provided that only inserts values into the data.
What problem does this PR solve?
There used to be many unused parameters in the function framework; this PR removes them.
The previous default-NULL handling framework inserted intermediate results into the block and then erased them — when blocks are large this caused significant overhead.
Now intermediates are handled using a temporary block, and a simple_insert function is provided that only inserts values into the data.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)