Skip to content

fix: reduce config warnings #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2025
Merged

fix: reduce config warnings #3018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7821627
fix: add error return to health server methods and reduce config warn…
CAICAIIs Sep 7, 2025
4c278cc
refactor: remove error returns from health server methods
CAICAIIs Sep 9, 2025
a4b7910
refactor: use precise type check for health server method validation
CAICAIIs Sep 10, 2025
9accb9e
style: fix formatting for health server method validation
CAICAIIs Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion common/rpc_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,11 @@ func suiteMethod(method reflect.Method) *MethodType {

// Reference is used to define service reference, and method with prefix 'XXX' is generated by triple pb tool.
// SetGRPCServer is used for pb reflection.
// Health helper methods are not RPCs and should be ignored.
// They should not to be checked.
if mname == "Reference" || mname == "SetGRPCServer" || strings.HasPrefix(mname, "XXX") {
if mname == "Reference" || mname == "SetGRPCServer" || strings.HasPrefix(mname, "XXX") ||
(method.Type.In(0).String() == "*health.HealthTripleServer" &&
(mname == "Resume" || mname == "SetServingStatus" || mname == "Shutdown")) {
return nil
}

Expand Down
6 changes: 5 additions & 1 deletion server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,11 @@ func (s *Server) genSvcOpts(handler any, opts ...ServiceOption) (*ServiceOptions
)
logger.Infof("Injected options from provider.services for %s", interfaceName)
} else {
logger.Warnf("No matching service config found for [%s]", interfaceName)
// Only warn if there are actually services configured but none match
// This avoids unnecessary warnings when using new server API without config files
if len(proCfg.Services) > 0 {
logger.Warnf("No matching service config found for [%s]", interfaceName)
}
}
}
// options passed by users have higher priority
Expand Down
Loading