feat: add row-based immutable data structure #181
Conversation
wgtmac
commented
Aug 16, 2025
wgtmac
commented
- Add StructLike, MapLike, and ArrayLike interfaces
- Add wrapper for ManifestFile and ArrowArray
wgtmac
force-pushed
the
struct_like
branch
3 times, most recently
from
472f2b9 to
60b93f8
Compare
wgtmac
force-pushed
the
struct_like
branch
4 times, most recently
from
86abc4b to
627093a
Compare
- Add StructLike, MapLike, and ArrayLike interfaces - Add wrapper for ManifestFile and ArrowArray
| @@ -567,4 +567,11 @@ Result<std::vector<ManifestFile>> ManifestListReaderImpl::Files() const { | |||
| return manifest_files; | |||
| } | |||
|
|
|||
| Result<ManifestFileField> ManifestFileFieldFromIndex(int32_t index) { | |||
| if (index >= 0 && index < static_cast<int32_t>(ManifestFileField::kNextId)) { | |||
There was a problem hiding this comment.
Would it be better to standardize the code format using index >= static_cast<int32_t>(ManifestFileField::kManifestPath) ?
There was a problem hiding this comment.
Why? The 1st value is always at index 0 regardless of its name. Perhaps kNextId is confusing.
|
@dongxiao1198 @mapleFU @zhjwpku @lidavidm Could you please take a look? |
src/iceberg/row/struct_like.h
Outdated
| std::string_view, // for non-owned string, binary and fixed | ||
| std::shared_ptr<StructLike>, // for struct |
There was a problem hiding this comment.
It's a bit confusing, if we want ownership, it might be:
Scalar = variant<Literal, std::shared_ptr<StructLike>, ...>If we don't want ownership, it would be:
<...
std::string_view,
const StructLike*,
const ArrayLike*,
...
>
Mixing string_view and sptr is so weird...
There was a problem hiding this comment.
And scalar seems re-invent some member in literal?
There was a problem hiding this comment.
These structures are all views. I don't want any ownership for string/binary/fixed/uuid, so use std::string_view and do not reuse Literal. But we need ownership for nested struct/map/list views, so sptr is used.
| /// Wrapper classes for manifest-related data structures that implement | ||
| /// StructLike, ArrayLike, and MapLike interfaces for unified data access. | ||
|
|
||
| #include <functional> |
There was a problem hiding this comment.
Because std::reference_wrapper is used in the header file.
