Core: Remove requiresNamespaceCreate check from TestRESTCatalog #14367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
approved these changes
Oct 20, 2025
| if (requiresNamespaceCreate()) { | ||
| catalog.createNamespace(TABLE.namespace()); | ||
| } | ||
| catalog.createNamespace(TABLE.namespace()); |
There was a problem hiding this comment.
requiresNamespaceCreate() depends on the backing catalog that is used in testing. I'm ok removing the check but I think one reason that might justify leaving the check in is when there are subclasses of TestRESTCatalog that have requiresNamespaceCreate() return false and allow creating implicit namespaces when the table is first created.
Let's see what others think here
There was a problem hiding this comment.
The rationale makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestRESTCatalog already knows its own behavior (requiresNamespaceCreate method always returns true).
This condition only makes sense for classes that don't know their behavior, such as abstract CatalogTests.