Skip to content

Conversation

@Tsukilc
Copy link
Contributor

@Tsukilc Tsukilc commented Jun 15, 2025

Purpose of the PR

for #2789
update hbase from 2.03 to 2.5.11 to remove java8 environment

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. dependencies Incompatible dependencies of package store Store module labels Jun 15, 2025
Comment on lines -39 to -40
<artifactId>hbase-shaded-endpoint</artifactId>
<version>2.0.6</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyxxoo any context about it?

Copy link
Contributor

@zyxxoo zyxxoo Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem was the protobuf version conflict with other package
https://issues.apache.org/jira/browse/HBASE-26097

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@Tsukilc Tsukilc Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyxxoo Maybe we need to create our own hbase-shaded-endpoint like
https://github.com/hugegraph/hbase/tree/HBASE-26097 ? I can try it.

@imbajin imbajin requested a review from Copilot June 16, 2025 06:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the HBase dependency from version 2.0.3 to 2.5.11 to remove the requirement for a Java8 environment. Key changes include updating dependency versions in known-dependencies.txt and pom.xml, modifying Travis installation scripts to use the new HBase distribution, and removing the custom hbase-site.xml configuration in favor of the default HBase standalone setup.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
install-dist/scripts/dependency/known-dependencies.txt Updated dependency versions and removed outdated jars
install-dist/release-docs/NOTICE Added Apache HBase NOTICE information
hugegraph-server/hugegraph-hbase/pom.xml Updated HBase dependency coordinates (groupId, artifactId, version)
hugegraph-server/hugegraph-dist/src/assembly/travis/install-hbase.sh Updated HBASE_VERSION and streamlined hbase startup commands
hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh Removed deprecated TODO comment for HBase backend installation
hugegraph-server/hugegraph-dist/src/assembly/travis/hbase-site.xml Removed custom HBase configuration file
.github/workflows/server-ci.yml Updated Java installation step and cleaned up redundant commands
Comments suppressed due to low confidence (3)

hugegraph-server/hugegraph-hbase/pom.xml:38

  • Verify that the updated groupId and artifactId ('org.apache.hbase' and 'hbase-endpoint') are correct and consistent with the official Maven coordinates for HBase 2.5.11 to ensure proper dependency resolution.
<groupId>org.apache.hbase</groupId>

hugegraph-server/hugegraph-dist/src/assembly/travis/install-hbase.sh:22

  • Update the inline comments to clarify the removal of the sudo commands and tmpfs configuration, explaining the rationale behind switching to the standalone start-hbase.sh script in this CI setup.
HBASE_VERSION="2.5.11"

hugegraph-server/hugegraph-dist/src/assembly/travis/hbase-site.xml:1

  • Ensure that the removal of the custom hbase-site.xml is intentional and that any necessary HBase configuration is now handled by default settings or another configuration file in the CI pipeline.
<?xml version="1.0"?>

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.40%. Comparing base (337dc86) to head (f72313e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (337dc86) and HEAD (f72313e). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (337dc86) HEAD (f72313e)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2803      +/-   ##
============================================
- Coverage     41.16%   34.40%   -6.76%     
+ Complexity      333      264      -69     
============================================
  Files           747      747              
  Lines         60123    60123              
  Branches       7676     7676              
============================================
- Hits          24750    20686    -4064     
- Misses        32793    37132    +4339     
+ Partials       2580     2305     -275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zyxxoo
zyxxoo previously approved these changes Jun 19, 2025
@zyxxoo zyxxoo dismissed their stale review June 19, 2025 14:10

need verify problem has been fixed

@VGalaxies
Copy link
Contributor

@github-actions
Copy link

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Incompatible dependencies of package inactive size:L This PR changes 100-499 lines, ignoring generated files. store Store module

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

4 participants