-
Couldn't load subscription status.
- Fork 563
refact(store): hbase from 2.0.3 to 2.5.11 #2803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| <artifactId>hbase-shaded-endpoint</artifactId> | ||
| <version>2.0.6</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zyxxoo any context about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem was the protobuf version conflict with other package
https://issues.apache.org/jira/browse/HBASE-26097
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your guidance. According to my observation, in 2.5.11, hbase still uses com.google.protobuf2.5
https://github.com/apache/hbase/blob/rel/2.5.11/pom.xml#L601
https://github.com/apache/hbase/blob/rel/2.5.11/hbase-endpoint/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zyxxoo Maybe we need to create our own hbase-shaded-endpoint like
https://github.com/hugegraph/hbase/tree/HBASE-26097 ? I can try it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the HBase dependency from version 2.0.3 to 2.5.11 to remove the requirement for a Java8 environment. Key changes include updating dependency versions in known-dependencies.txt and pom.xml, modifying Travis installation scripts to use the new HBase distribution, and removing the custom hbase-site.xml configuration in favor of the default HBase standalone setup.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| install-dist/scripts/dependency/known-dependencies.txt | Updated dependency versions and removed outdated jars |
| install-dist/release-docs/NOTICE | Added Apache HBase NOTICE information |
| hugegraph-server/hugegraph-hbase/pom.xml | Updated HBase dependency coordinates (groupId, artifactId, version) |
| hugegraph-server/hugegraph-dist/src/assembly/travis/install-hbase.sh | Updated HBASE_VERSION and streamlined hbase startup commands |
| hugegraph-server/hugegraph-dist/src/assembly/travis/install-backend.sh | Removed deprecated TODO comment for HBase backend installation |
| hugegraph-server/hugegraph-dist/src/assembly/travis/hbase-site.xml | Removed custom HBase configuration file |
| .github/workflows/server-ci.yml | Updated Java installation step and cleaned up redundant commands |
Comments suppressed due to low confidence (3)
hugegraph-server/hugegraph-hbase/pom.xml:38
- Verify that the updated groupId and artifactId ('org.apache.hbase' and 'hbase-endpoint') are correct and consistent with the official Maven coordinates for HBase 2.5.11 to ensure proper dependency resolution.
<groupId>org.apache.hbase</groupId>
hugegraph-server/hugegraph-dist/src/assembly/travis/install-hbase.sh:22
- Update the inline comments to clarify the removal of the sudo commands and tmpfs configuration, explaining the rationale behind switching to the standalone start-hbase.sh script in this CI setup.
HBASE_VERSION="2.5.11"
hugegraph-server/hugegraph-dist/src/assembly/travis/hbase-site.xml:1
- Ensure that the removal of the custom hbase-site.xml is intentional and that any necessary HBase configuration is now handled by default settings or another configuration file in the CI pipeline.
<?xml version="1.0"?>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2803 +/- ##
============================================
- Coverage 41.16% 34.40% -6.76%
+ Complexity 333 264 -69
============================================
Files 747 747
Lines 60123 60123
Branches 7676 7676
============================================
- Hits 24750 20686 -4064
- Misses 32793 37132 +4339
+ Partials 2580 2305 -275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Tsukilc plz also update https://github.com/apache/incubator-hugegraph/blob/master/install-dist/release-docs/LICENSE accordingly |
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
Purpose of the PR
for #2789
update hbase from 2.03 to 2.5.11 to remove java8 environment
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need