Skip to content

improve: raft state machine should report error #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve: raft state machine should report error #2871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/raft/RaftStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ public void onApply(Iterator iter) {
if (done != null) {
done.run(new Status(RaftError.EINTERNAL, t.getMessage()));
}
iter.setErrorAndRollback(1, new Status(RaftError.ESTATEMACHINE, t.getMessage()));
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The hardcoded rollback count '1' should be extracted as a named constant to improve code readability and maintainability. Consider defining a constant like 'ROLLBACK_COUNT = 1' to make the intent clearer.

Copilot uses AI. Check for mistakes.
}
iter.next();
}
Expand Down
1 change: 1 addition & 0 deletions ...tore/hg-store-core/src/main/java/org/apache/hugegraph/store/raft/HgStoreStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ public void onApply(Iterator inter) {
done.op.getReq());
// done.run(new Status(RaftError.EINTERNAL, t.getMessage()));
}
inter.setErrorAndRollback(1, new Status(RaftError.ESTATEMACHINE, t.getMessage()));
}
committedIndex = inter.getIndex();

Expand Down
Loading