feature: support Oracle Batch Insert #7675

maple525866 · 2025-09-29T14:41:33Z

I have read the CONTRIBUTING.md guidelines.
I have registered the PR changes.

Ⅰ. Describe what this PR did

Problem Background
Seata cannot support Oracle's INSERT ALL batch insert statements. For example, insert all into a (id) values(1) into a (id) values(2) SELECT 1 FROM DUAL will be parsed as OracleMultiInsertStatement, but DruidSQLRecognizerFactoryImpl does not support this statement type.
Solution

Extend DruidSQLRecognizerFactoryImpl to add support for OracleMultiInsertStatement
Extend OracleOperateRecognizerHolder to add methods specifically for handling multiple inserts
Create OracleMultiInsertRecognizer and use ast.getEntries() to obtain insert items. It supports parsing multiple INSERT INTO clauses and correctly handles various data types (NULL, parameter placeholders, sequences, etc.)

Verification Functionality -> Created OracleMultiInsertRecognizerTest containing 11 test cases:

Basic functional testing: SQL type, table name, table alias
Column processing testing: Insert column retrieval, empty column detection
Data row testing: Basic data, NULL values, parameter placeholders, primary key processing
Complex scenario testing: Multi-table inserts, complex statements, edge cases
Interface consistency testing: Ensures compliance with the Seata interface specification

Ⅱ. Does this pull request fix one issue?

fixes #7607

Ⅲ. Why don't you add test cases (unit test/integration test)?

UT have been added

Ⅳ. Describe how to verify it

mvn clean test

Ⅴ. Special notes for reviews

Currently, only single-table Oracle INSERT batching is supported. I don't believe multi-table support is necessary because branching transactions can be useful.❤️

codecov · 2025-09-29T17:27:00Z

Codecov Report

❌ Patch coverage is 66.34615% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.53%. Comparing base (d239a81) to head (d350bf6).
⚠️ Report is 1 commits behind head on 2.x.

Files with missing lines	Patch %	Lines
...rser/druid/oracle/OracleMultiInsertRecognizer.java	68.04%	19 Missing and 12 partials ⚠️
...sqlparser/druid/DruidSQLRecognizerFactoryImpl.java	50.00%	2 Missing and 1 partial ⚠️
...er/druid/oracle/OracleOperateRecognizerHolder.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #7675      +/-   ##
============================================
+ Coverage     61.38%   61.53%   +0.15%     
+ Complexity      684      680       -4     
============================================
  Files          1323     1324       +1     
  Lines         49943    50047     +104     
  Branches       5885     5910      +25     
============================================
+ Hits          30657    30796     +139     
+ Misses        16524    16447      -77     
- Partials       2762     2804      +42

Files with missing lines	Coverage Δ
...er/druid/oracle/OracleOperateRecognizerHolder.java	`87.50% <0.00%> (-12.50%)`	⬇️
...sqlparser/druid/DruidSQLRecognizerFactoryImpl.java	`81.81% <50.00%> (-5.03%)`	⬇️
...rser/druid/oracle/OracleMultiInsertRecognizer.java	`68.04% <68.04%> (ø)`

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

...rser-druid/src/main/java/org/apache/seata/sqlparser/druid/DruidSQLRecognizerFactoryImpl.java

...druid/src/main/java/org/apache/seata/sqlparser/druid/oracle/OracleMultiInsertRecognizer.java

YoWuwuuuw · 2025-09-30T08:49:42Z

...druid/src/main/java/org/apache/seata/sqlparser/druid/oracle/OracleMultiInsertRecognizer.java

By default, only the insert all syntax of Oracle Batch Insert and the same column situation is supported. The same effect can be achieved by adding multiple values clauses to a normal insert. Are there plans to support more in the future?

Currently, we only support batch insert of multiple columns (same columns) in a single table. We will continue to support this in the future.

maple525866 · 2025-10-02T14:58:20Z

First, thanks to @YoWuwuuuw for the bug report.❤️

For now, I think we can start with basic support, like this pull request, which supports batch inserts for multiple columns in a single table.

However, for other scenarios, such as support for insert-first syntax and ConditionalInsertClause, further support can be implemented through other pull requests.

For multi-table scenarios, I don't think support is necessary at this time.

Copilot

Pull Request Overview

This PR adds support for Oracle's INSERT ALL (multi-insert) batch statements in Seata. The implementation extends the SQL parser to handle Oracle-specific bulk insert syntax that was previously unsupported.

Added Oracle multi-insert recognizer to parse and validate INSERT ALL statements
Extended factory and holder classes to support the new statement type
Enforced single-table constraint with consistent column definitions for transaction safety

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
OracleMultiInsertRecognizer.java	New recognizer class implementing SQLInsertRecognizer interface for Oracle INSERT ALL statements
OracleOperateRecognizerHolder.java	Added method to create multi-insert recognizers
DruidSQLRecognizerFactoryImpl.java	Extended factory to handle OracleMultiInsertStatement AST nodes
OracleMultiInsertRecognizerTest.java	Comprehensive test suite with 11 test cases covering functionality and edge cases
DruidSQLRecognizerFactoryTest.java	Updated factory tests with multi-insert and INSERT FIRST scenarios
changes files	Documentation updates for the new feature

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

...d/src/test/java/org/apache/seata/sqlparser/druid/oracle/OracleMultiInsertRecognizerTest.java

maple525866 · 2025-10-11T14:19:01Z

@funky-eyes PTAL❤️ If you have any further questions please let me know

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-17T05:38:41Z

...rser-druid/src/test/java/org/apache/seata/sqlparser/druid/DruidSQLRecognizerFactoryTest.java

+        // 1.sql
+        String sql = "INSERT ALL INTO a(id) VALUES(1) INTO a(id) VALUES(2) SELECT 1 FROM dual";
+
+        SQLStatement stmt = SQLUtils.parseSingleStatement(sql, "oracle");
+        assertTrue(stmt instanceof OracleMultiInsertStatement);
+
+        // 2. mock recognizerHolder and recognizer


Comment formatting inconsistency: '1.sql' should be '1. SQL' to match the style of '2. mock recognizerHolder and recognizer' and '3. stub getMultiInsertRecognizer'.

...druid/src/main/java/org/apache/seata/sqlparser/druid/oracle/OracleMultiInsertRecognizer.java

…/sqlparser/druid/oracle/OracleMultiInsertRecognizer.java Co-authored-by: Copilot <[email protected]>

funky-eyes

LGTM

YvCeung · 2025-10-17T07:11:29Z

Well done. The code format verification failed due to other PR(#7643 ) and will be fixed later.

YvCeung · 2025-10-17T07:11:37Z

LGTM

maple added 6 commits September 29, 2025 00:46

feature: Added support for Oracle insert batch

336b9bc

opt: provides support for multiple insertions

210147e

test: add UT

f98bd61

opt: spotless apply

aaa1589

fix: add License

35e518d

Merge branch 'refs/heads/2.x' into feature/oracle_batch_insert

6af3533

YoWuwuuuw reviewed Sep 30, 2025

View reviewed changes

maple added 5 commits October 2, 2025 20:29

bugfix: throw exceptions for currently unsupported situations

8e68f03

bugfix: exception thrown for ConditionalInsertClause

1a91697

bugfix: throw the corresponding exception for insert first

342daf7

test: add UT

8d50934

opt: spotless:apply

82d32e1

maple added 2 commits October 2, 2025 23:22

Merge branch 'refs/heads/2.x' into feature/oracle_batch_insert

495185a

2.x md change

ecd619b

funky-eyes requested a review from Copilot October 10, 2025 02:28

Copilot AI reviewed Oct 10, 2025

View reviewed changes

...d/src/test/java/org/apache/seata/sqlparser/druid/oracle/OracleMultiInsertRecognizerTest.java Show resolved Hide resolved

Merge branch '2.x' into feature/oracle_batch_insert

8ccd886

YvCeung added the DB: Oracle Relate to seata Oracle label Oct 16, 2025

funky-eyes added mode: AT AT transaction mode module/rm-datasource rm-datasource module module/sqlparser sql-parser module multilingual labels Oct 17, 2025

Merge branch '2.x' into feature/oracle_batch_insert

7762359

funky-eyes added this to the 2.6.0 milestone Oct 17, 2025

funky-eyes requested a review from Copilot October 17, 2025 05:38

Copilot AI reviewed Oct 17, 2025

View reviewed changes

Update sqlparser/seata-sqlparser-druid/src/main/java/org/apache/seata…

be9f39b

…/sqlparser/druid/oracle/OracleMultiInsertRecognizer.java Co-authored-by: Copilot <[email protected]>

funky-eyes approved these changes Oct 17, 2025

View reviewed changes

Merge branch '2.x' into feature/oracle_batch_insert

d350bf6

YvCeung merged commit 9b97559 into apache:2.x Oct 17, 2025
14 of 16 checks passed

slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025

feature: support Oracle Batch Insert (apache#7675)

4aff628

feature: support Oracle Batch Insert #7675

feature: support Oracle Batch Insert #7675

Uh oh!

Conversation

maple525866 commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

codecov bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YoWuwuuuw Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

maple525866 Oct 2, 2025

Choose a reason for hiding this comment

Uh oh!

maple525866 commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

maple525866 commented Oct 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

YvCeung commented Oct 17, 2025

Uh oh!

YvCeung commented Oct 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

maple525866 commented Sep 29, 2025 •

edited

Loading

codecov bot commented Sep 29, 2025 •

edited

Loading

maple525866 commented Oct 2, 2025 •

edited

Loading