-
Notifications
You must be signed in to change notification settings - Fork 961
Cleanup metadata with batch size and interval #7176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
turboFei
wants to merge
8
commits into
apache:master
Choose a base branch
from
turboFei:clean_batch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
842d7fe
to
f6797c9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7176 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 701 701
Lines 43565 43601 +36
Branches 5911 5917 +6
======================================
- Misses 43565 43601 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pan3793
reviewed
Aug 28, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JdbcDatabaseDialect.scala
Outdated
Show resolved
Hide resolved
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataStore.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala
Outdated
Show resolved
Hide resolved
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala
Outdated
Show resolved
Hide resolved
thanks @pan3793, have addressed all comments |
pan3793
reviewed
Aug 28, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Aug 28, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala
Outdated
Show resolved
Hide resolved
addressed the comments |
pan3793
reviewed
Aug 28, 2025
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/MetadataManager.scala
Outdated
Show resolved
Hide resolved
…/MetadataManager.scala
pan3793
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Cleanup metadata with batch size and interval to prevent hold the lock for long time if the metadata size is huge.
How was this patch tested?
GA.
Was this patch authored or co-authored using generative AI tooling?
No.