Update code comment after bumping block size to 256. #15177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag we store at the beginning of every block is either 0 if the block is dense, a positive integer storing the number of bits per value if encoded with FOR-delta, or a negative number storing the opposite of the number of longs required when encoded as a bit set. This PR updates the comment that explains why we're guaranteed to not overflow a byte with the number of required longs.
jpountz
added
the
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag we store at the beginning of every block is either 0 if the block is dense, a positive integer storing the number of bits per value if encoded with FOR-delta, or a negative number storing the opposite of the number of longs required when encoded as a bit set.
This PR updates the comment that explains why we're guaranteed to not overflow a byte with the number of required longs.