Feature/move long array group varint to backward codecs 15113 #15186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move deprecated long[] group varint methods from core to backward-codecs - Remove GroupVIntUtil.readGroupVInts(DataInput, long[], int) from core - Remove GroupVIntUtil.writeGroupVInts(DataOutput, byte[], long[], int) from core - Remove DataOutput.writeGroupVInts(long[], int) from core - Add GroupVIntUtil class in backward-codecs with long[] methods - Add DataOutputUtil class in backward-codecs for long[] DataOutput operations - Add comprehensive tests for the moved functionality - Prevents accidental usage of legacy long[] methods in benchmarks - Maintains backward compatibility for codecs that need long[] functionality Fixes apache#15113
Add changelog entry documenting the move of long[] group varint methods to backward-codecs module as required by contributing guidelines.
- Update existing PostingsUtil files in lucene912 and lucene99 to use backward-codecs GroupVIntUtil - Remove deprecated testGroupVIntOverflow from test framework - Fix TestGroupVIntUtil to use ByteBuffersDataOutput/Input correctly - All tests now pass with Java 24 - Implementation is fully functional and tested Resolves remaining compilation errors from apache#15113
- Removed lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/util/TestGroupVIntUtil.java - Keeping the correct version at lucene/backward-codecs/src/test/java/org/apache/lucene/backward_codecs/util/TestGroupVIntUtil.java - This follows proper Maven directory structure with src/test/java/ path
- Remove trailing spaces from blank lines in TestGroupVIntUtil.java - Fix formatting in BaseDirectoryTestCase.java - Resolves checkGoogleJavaFormat validation errors
- Fixes TestModularLayer.testAllExportedPackagesInSync test failure - The util package contains GroupVIntUtil and related backward compatibility utilities - Required for proper module system compliance in Java 9+ environments
- Add package-info.java for org.apache.lucene.backward_codecs.util package - Add Javadoc comment for GroupVIntUtil.MAX_LENGTH_PER_GROUP field - Resolves Javadoc validation errors in CI builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: Move long[] group varint to backward-codecs #15113