feat(bindings/c): async stat #6072
Open
+705
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
asukaminato0721
force-pushed
the
c-async
branch
2 times, most recently
from
1799b3c to
8b4901e
Compare
Xuanwo
requested changes
Apr 22, 2025
asukaminato0721
force-pushed
the
c-async
branch
from
664446c to
1adf686
Compare
Member
|
Hi, I tend to leave the C binding AS IS until we have an actual user utilizing the C binding in a production environment who can show us how they use the library’s async API. Alternatively, we could wait until we have a comprehensive design for how the C binding’s async functionality should work. For example, how should we handle the existing Tokio code? Should we consider splitting the library into a blocking version and an async version? We can wait for #6082 to reach a consensus. I'm concerned about choosing a direction without sufficient information. In fact, the C binding itself is powered by Tokio, which runs all I/O asynchronously, but currently, we only provide users with a blocking API. |
asukaminato0721
force-pushed
the
c-async
branch
2 times, most recently
from
917f677 to
fa8ef87
Compare
asukaminato0721
force-pushed
the
c-async
branch
2 times, most recently
from
808ec60 to
4edd344
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #5366 .
part of #1741
Rationale for this change
What changes are included in this PR?
add c async stat support
Are there any user-facing changes?
user can use c async stat.