require whisk auth fix #480
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven0711dong
force-pushed
the
requirewhiskauthformatfix
branch
from
92e7523 to
1de1d9c
Compare
rabbah
reviewed
Jan 7, 2021
Member
rabbah
left a comment
rabbah
left a comment
There was a problem hiding this comment.
I apologize no one reviewed this sooner. I added a comment about generating alphanumeric secrets instead of integer only. Also this needs either some go unit tests or integration (scala) tests.
| } | ||
|
|
||
| func getNewSecret(secret interface{}) string { | ||
| _, isJSONNum := secret.(json.Number) |
Member
There was a problem hiding this comment.
I'd replace this with the ability to generate an alphanumeric secret instead.
Something like:
rand.Seed(time.Now().UnixNano())
var alphabet = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
b := make([]rune, SECRET_LENGTH)
for i := range b {
b[i] = alphabet[rand.Intn(len(alphabet))]
}
return string(b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.