Refactor Kafka client configuration to use a new ClientConfig struct #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Kafka client configuration by introducing a new
ClientConfig
struct to replace the use ofRDKafkaClientConfig
directly. The changes improve code clarity, encapsulation, and configurability, particularly by adding support for a custom log level. The most important changes include replacingRDKafkaClientConfig
withClientConfig
in multiple files, implementing the newClientConfig
struct, and updating theKafkaReportBuilder
to use the new configuration.Refactoring Kafka Client Configuration:
Introduction of
ClientConfig
struct:ClientConfig
struct insrc/reporter/kafka.rs
, encapsulating Kafka configuration parameters and log levels. It includes methods for setting parameters, setting log levels, and converting toRDKafkaClientConfig
. [1] [2]Replacement of
RDKafkaClientConfig
withClientConfig
:RDKafkaClientConfig
inREADME.md
ande2e/src/main.rs
to use the newClientConfig
struct. [1] [2] [3]Updates to
KafkaReportBuilder
:KafkaReportBuilder
to useClientConfig
:KafkaReportBuilder
struct and its methods to accept and work withClientConfig
instead ofRDKafkaClientConfig
. This includes changes to thenew
,new_with_pc
, andbuild
methods. [1] [2] [3]These changes enhance the maintainability and flexibility of the Kafka client configuration by abstracting the configuration details into a dedicated struct.