Skip to content

Conversation

zhouyuan
Copy link

@zhouyuan zhouyuan commented Aug 19, 2025

What changes were proposed in this pull request?

By default Spark only propagate configurations with "spark" prefix to executor side.
This patch added a new configuration to define a comma based list, configurations with such prefix will propagated to executor side.
This will help to pass session level configurations to new native execution engine like Gluten project.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

@github-actions github-actions bot added the SQL label Aug 19, 2025
@zhouyuan zhouyuan force-pushed the wip_spark_config_prefix branch from 79fc7e2 to 4cbf645 Compare August 19, 2025 11:24
@pan3793
Copy link
Member

pan3793 commented Aug 19, 2025

Many places in Spark code ignore configs without spark. prefix, do you have a concrete case that requires breaking this contract?

@@ -458,6 +458,13 @@ object SQLConf {
.booleanConf
.createWithDefault(true)

val PROPAGATE_CONF_PREFIXES = buildConf("spark.sql.propagateConfPrefixes")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Hadoop and Hive configurations have also been mandated to include the prefix spark.. Several systems have been developed based on this understanding. Why then can the gluten configuration not adhere to the same standard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants