-
Notifications
You must be signed in to change notification settings - Fork 28.8k
[SPARK-53355][PYTHON][SQL][INFRA] test python udf type behavior #52105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@HyukjinKwon and @asl could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
return [ | ||
("byte_values", ByteType(), df([(-128,), (127,), (0,)])), | ||
("byte_null", ByteType(), df([(None,), (42,)])), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add a comment with context about the null handling importance for input type vs. return type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you have an example, what comment are you looking for exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional nit, but i meant we could clarify how the test cases for the return_types and input_types were decided
@@ -0,0 +1,5 @@ | |||
These tests capture input/output type interfaces between python udfs and the engine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to run this in CI? If so, we should add __init__.py
,and add this modul into dev/sparktestsupport/modules.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, let me try to add it. Do we need any other reviewer for the infra changes?
My only concern is that I don't think we should say this is the standard behaviours ... as some of behaviours are weird. I am fine with this change as long as we're all on the same page that some behaviours here might change in the future. |
Yes, agreed. I've also updated the readme to reflect that these tests are purely internal and not an API documentation |
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Yes, used claude to generate the table printing utils. Generated-by: claude-sonnet-4