Refactor SQL module to use PreparedStatement (#1611) #1612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors parts of the SQL module to use
PreparedStatement
instead of SQL string concatenation, in accordance with issue #1611.✅ Refactored:
SQLSpout.java
: replaced string-based query building withPreparedStatement
IndexerBolt.java
: refactored dynamic insert with metadata into a clean, safePreparedStatement
☑️
StatusUpdaterBolt.java
already usedPreparedStatement
correctly and did not require changes.The module compiles cleanly with
mvn clean install -DskipTests
and follows recommended SQL practices.Closes #1611