Fix autoencoder bias gradient updates #2330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use bias gradients (b1_grad, b2_grad, etc.) instead of bias values (b1, b2, etc.) in momentum updates. This critical fix ensures proper backpropagation and training convergence in the 2-layer autoencoder. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
Hi @VirenS13117 , thanks for looking into this. Have you verified the fix? and in which scenario you've found this as bug? |
|
It is definitely a bug, and a nice catch. Will merge once I verify the GitHub actions. |
|
@j143 well it's a logical bug as this was taking bias values instead of gradients. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bias gradients (b1_grad, b2_grad, etc.) instead of bias values (b1, b2, etc.) in momentum updates. This critical fix ensures proper backpropagation and training convergence in the 2-layer autoencoder.