Skip to content

Conversation

christinadionysio
Copy link
Contributor

This commit divides the installation of packages into a part that installs all generally needed packages and one part that is only installed for specific test runs like Scuro. Additionally, torch hub get's cached which reduces setup time.

@Baunsgaard
Copy link
Contributor

LGTM, feel free to merge.

@Baunsgaard
Copy link
Contributor

it would be good to additionally cache the datasets you use, see:

    - name: Cache Datasets
      uses: actions/cache@v4
      with:
        path: |
          src/main/python/systemds/examples/tutorials/mnist
          src/main/python/systemds/examples/tutorials/adult/data.zip
        key: ${{ runner.os }}-mnist-${{ hashFiles('src/main/python/systemds/examples/tutorials/mnist.py') }}-${{ hashFiles('src/main/python/systemds/examples/tutorials/adult.py') }}

@christinadionysio christinadionysio merged commit 9f8e37a into apache:main Oct 9, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in SystemDS PR Queue Oct 9, 2025
@christinadionysio christinadionysio deleted the pkg_dependencies branch October 9, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants