Skip to content

Conversation

kirill-stepanishin
Copy link
Contributor

@kirill-stepanishin kirill-stepanishin commented Oct 10, 2025

Summary

Integrates Go Gremlin examples into CI to ensure they remain functional in future releases. Examples now execute automatically after integration tests and fail the build if broken.

Changes Made

  • Added example execution to gremlin-go-integration-tests container in docker-compose.yml
  • Made server URLs configurable via environment variables (replaces hardcoded localhost:8182)
  • Use specialized labels to isolate test data
  • Build fails if any example fails to execute

@kirill-stepanishin kirill-stepanishin force-pushed the go-examples-integration branch 2 times, most recently from 1eecee3 to 80f7885 Compare October 10, 2025 23:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.25%. Comparing base (9b46b67) to head (6df0a43).
⚠️ Report is 387 commits behind head on 3.7-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##             3.7-dev    #3239      +/-   ##
=============================================
+ Coverage      76.14%   76.25%   +0.10%     
- Complexity     13152    13312     +160     
=============================================
  Files           1084     1092       +8     
  Lines          65160    67657    +2497     
  Branches        7285     7378      +93     
=============================================
+ Hits           49616    51590    +1974     
- Misses         12839    13324     +485     
- Partials        2705     2743      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirill-stepanishin kirill-stepanishin force-pushed the go-examples-integration branch 2 times, most recently from 1ea370d to 4c1402a Compare October 15, 2025 20:08
@kirill-stepanishin kirill-stepanishin marked this pull request as ready for review October 15, 2025 21:42
- Add examples execution to gremlin-go-integration-tests container
- Make server URLs configurable via environment variables
- Use specialized labels (person-go-ex, go-conn-ex) to isolate test data
- Build fails if any example fails to execute
- Replace port placeholder logic with getEnvOrDefaultString() helper
- Use configurable vertex labels in examples
@andreachild
Copy link
Contributor

Please add a changelog entry thanks!

@andreachild
Copy link
Contributor

VOTE +1 pending changelog entry

@kirill-stepanishin
Copy link
Contributor Author

VOTE +1 pending changelog entry

Added a generic changelog entry for all GLV examples in #3231

@xiazcy
Copy link
Contributor

xiazcy commented Oct 17, 2025

VOTE +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants