chore: introduce the instance crd #9546

leon-inf · 2025-07-17T08:32:35Z

No description provided.

apecloud-bot · 2025-07-17T08:32:48Z

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

leon-inf · 2025-07-17T08:33:01Z

/nopick

codecov · 2025-07-17T08:48:40Z

Codecov Report

❌ Patch coverage is 54.61821% with 1361 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.62%. Comparing base (f8afb5a) to head (532f11a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...controller/instance/reconciler_assistant_object.go	6.75%	136 Missing and 2 partials ⚠️
pkg/controller/builder/builder_instance.go	0.00%	117 Missing ⚠️
.../controller/instanceset2/assistant_object_utils.go	6.61%	112 Missing and 1 partial ⚠️
pkg/controller/instance/in_place_update_utils.go	52.13%	88 Missing and 24 partials ⚠️
pkg/controller/instanceset2/instance_util.go	57.25%	92 Missing and 17 partials ⚠️
pkg/controller/instance/utils.go	60.16%	81 Missing and 15 partials ⚠️
pkg/controller/instanceset2/update_plan.go	43.57%	76 Missing and 3 partials ⚠️
pkg/controller/instanceset2/reconciler_status.go	74.43%	51 Missing and 17 partials ⚠️
pkg/controller/instance/reconciler_update.go	60.86%	45 Missing and 18 partials ⚠️
pkg/controller/instance/pod_role_event_handler.go	10.44%	60 Missing ⚠️
... and 25 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9546      +/-   ##
==========================================
- Coverage   59.94%   59.62%   -0.32%     
==========================================
  Files         518      551      +33     
  Lines       56636    59931    +3295     
==========================================
+ Hits        33948    35734    +1786     
- Misses      19636    20936    +1300     
- Partials     3052     3261     +209

Flag	Coverage Δ
unittests	`59.62% <54.61%> (-0.32%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cjc7373 · 2025-08-13T08:50:15Z

What's the main advantage of introducing the new instance api?

zjx20 · 2025-08-20T03:00:39Z

pkg/controller/instance/pod_role_event_handler.go

+	snapshotVersion := strconv.FormatInt(event.EventTime.UnixMicro(), 10)
+	lastSnapshotVersion, ok := pod.Annotations[constant.LastRoleSnapshotVersionAnnotationKey]
+	if ok {
+		if snapshotVersion <= lastSnapshotVersion && !strings.Contains(lastSnapshotVersion, ":") {


A bug related to time comparison will be introduced here. It will be triggered in about 200 years, although we'll all be gone by then. :) It's recommended to also compare the lengths of the two strings.

zjx20 · 2025-08-20T09:27:54Z

pkg/controller/instanceset2/reconciler_revision_update.go

+func (r *revisionUpdateReconciler) Reconcile(tree *kubebuilderx.ObjectTree) (kubebuilderx.Result, error) {
+	its, _ := tree.GetRoot().(*workloads.InstanceSet)
+
+	updatedReplicas, err := r.calculateUpdatedReplicas(its, tree.List(&workloads.Instance{}))


err is always nil.

zjx20 · 2025-08-20T17:52:53Z

pkg/controller/instance/reconciler_status.go

+		}
+	}
+
+	// TODO: ???


The code was introduced by #8151. I think it's still useful.

It is not supported within the instance API.

zjx20 · 2025-08-21T01:43:54Z

pkg/controller/instanceset2/instance_util.go

+	// merge pvcs
+	for i := range newInst.Spec.VolumeClaimTemplates {
+		newPVC := &newInst.Spec.VolumeClaimTemplates[i]
+		oldPVC := &targetInst.Spec.VolumeClaimTemplates[i]


Potential out-of-bound error?

zjx20 · 2025-08-21T02:48:57Z

pkg/controller/instanceset2/instance_util.go

+
+	copyNMergeAssistantObjects := func() {
+		for i := range newInst.Spec.InstanceAssistantObjects {
+			oldObj := &targetInst.Spec.InstanceAssistantObjects[i]


zjx20 · 2025-08-21T07:23:04Z

pkg/controller/instance/in_place_update_utils.go

+		}
+		return true
+	case []corev1.Toleration:
+		return true


Why are tolerations ignored?

zjx20 · 2025-08-21T08:11:15Z

pkg/controller/instance/reconciler_assistant_object.go

+		return false, err
+	}
+	if err != nil || robj == nil {
+		labels := obj.GetLabels()


labels can be nil?

zjx20 · 2025-08-21T08:38:28Z

pkg/controller/instance/reconciler_alignment.go

+	for _, object := range oldPodList {
+		oldNameSet.Insert(object.GetName())
+	}
+	deleteNameSet := oldNameSet.Difference(newNameSet)


Since the newNameSet only contains inst.name, in what case will oldNameSet contain another value?

Re-implemented it.

zjx20 · 2025-08-21T09:05:35Z

pkg/controller/instance/reconciler_update.go

+		meta.RemoveStatusCondition(&inst.Status.Conditions, string(workloads.InstanceUpdateRestricted))
+	}
+	if needRetry {
+		return kubebuilderx.RetryAfter(time.Second * time.Duration(inst.Spec.MinReadySeconds)), nil


inst.Spec.MinReadySeconds can be zero. Maybe sleep for at least a few seconds.

That needRetry is true indicates that the minReadySeconds is not 0.

zjx20 · 2025-08-21T09:27:41Z

pkg/controller/instance/revision_utils.go

+var (
+	codecs         = serializer.NewCodecFactory(model.GetScheme())
+	patchCodec     = codecs.LegacyCodec(workloads.SchemeGroupVersion)
+	controllerKind = appsv1.SchemeGroupVersion.WithKind("StatefulSet")


"InstanceSet"? Although it affects nothing.

zjx20 · 2025-08-21T11:46:27Z

apis/workloads/v1/instance_types.go

+	ConfigMap      *corev1.ConfigMap      `json:"configMap,omitempty"`
+	Secret         *corev1.Secret         `json:"secret,omitempty"`
+	ServiceAccount *corev1.ServiceAccount `json:"serviceAccount,omitempty"`
+	Role           *rbacv1.Role           `json:"clusterRole,omitempty"`


clusterRole => role

leon-inf added 9 commits July 3, 2025 18:39

init

e5b5838

Merge branch 'main' into support/instance-crd

b659456

Merge branch 'main' into support/instance-crd

219f983

update

e213264

Merge branch 'main' into support/instance-crd

3ca0531

update

78a4453

Merge branch 'main' into support/instance-crd

7f38817

update

109cdbc

Merge branch 'main' into support/instance-crd

ae7230f

leon-inf added this to the Release 1.1.0 milestone Jul 17, 2025

github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Jul 17, 2025

apecloud-bot added the nopick Not auto cherry-pick when PR merged label Jul 17, 2025

leon-inf force-pushed the support/instance-crd branch from 0f9f3f1 to d169a30 Compare July 17, 2025 08:37

update

688d714

leon-inf force-pushed the support/instance-crd branch from d169a30 to 688d714 Compare July 17, 2025 08:56

Merge branch 'main' into support/instance-crd

12c56ec

leon-inf force-pushed the support/instance-crd branch 11 times, most recently from 6154703 to f9cfcae Compare July 22, 2025 05:57

leon-inf added 10 commits July 24, 2025 17:54

Merge branch 'main' into support/instance-crd

ac3d00d

update inst status api

68c31dc

update cluster API

e5aad97

fix update inst

e408bdb

condition to clone assistant objects

4bd1920

Merge branch 'main' into support/instance-crd

4ba4b95

update

8c24431

component services

2f4ece8

instance controller test

68a6c89

Merge branch 'main' into support/instance-crd

8d677bc

leon-inf force-pushed the support/instance-crd branch 4 times, most recently from 428a60d to 611875e Compare August 8, 2025 09:21

leon-inf marked this pull request as ready for review August 8, 2025 09:23

leon-inf requested a review from a team as a code owner August 8, 2025 09:23

leon-inf force-pushed the support/instance-crd branch from 611875e to 784684f Compare August 8, 2025 10:01

its2 test

3f2d28d

leon-inf force-pushed the support/instance-crd branch from 784684f to 3f2d28d Compare August 8, 2025 10:08

Merge branch 'main' into support/instance-crd

1cf1fe6

zjx20 reviewed Aug 21, 2025

View reviewed changes

leon-inf added 2 commits August 22, 2025 10:07

Merge branch 'main' into support/instance-crd

8c7f7ad

Merge branch 'main' into support/instance-crd

2c6a10a

leon-inf force-pushed the support/instance-crd branch 3 times, most recently from edd75f5 to 532f11a Compare August 22, 2025 07:37

fix

a0aeedb

leon-inf force-pushed the support/instance-crd branch from 532f11a to a0aeedb Compare August 22, 2025 08:44

chore: introduce the instance crd #9546

Are you sure you want to change the base?

chore: introduce the instance crd #9546

Uh oh!

Conversation

leon-inf commented Jul 17, 2025

Uh oh!

apecloud-bot commented Jul 17, 2025

Uh oh!

leon-inf commented Jul 17, 2025

Uh oh!

codecov bot commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

cjc7373 commented Aug 13, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jul 17, 2025 •

edited

Loading