Enables y-scroll on textarea resize - Fixes issue 132

.hound.yml

@@ -7,6 +7,6 @@ eslint:
 python:
   enabled: true
   config_file: tools/.flake8.ini
-scss:
+sass-lint:
   enabled: true
-  config_file: assets/css/.scss-lint.yml
+  config_file: assets/css/.sass-lint.yml

.travis.yml

@@ -1,9 +1,16 @@
+sudo: required
+dist: trusty
 language: node_js
 node_js:
   - stable
+before_install:
+  - sudo apt-get install python3 python3-pip
+install:
+  - npm install jsonlint eslint htmlhint sass-lint -g
+  - pip3 install flake8
 script:
   - find assets/strings -type f -name '*.json' -exec jsonlint -q '{}' +
-  - eslint -c assets/js/.eslintrc.json assets/js/*.js
+  - eslint --config assets/js/.eslintrc.json assets/js/*.js
   - htmlhint --config .htmlhintrc.json *.html
-before_install:
-  - npm install jsonlint eslint htmlhint -g
+  - sass-lint --config assets/css/.sass-lint.yml --verbose --no-exit --max-warnings 0
+  - flake8 --config tools/.flake8.ini *.py **/**.py **/**/*.py

assets/css/.sass-lint.yml

@@ -0,0 +1,19 @@
+files:
+  ignore: assets/css/bootstrap.css
+  include: 'assets/css/**/*.css'
+rules:
+  no-ids: 0
+  single-line-per-selector: 0
+  no-color-literals: 0
+  force-element-nesting: 0
+  force-pseudo-nesting: 0
+  force-attribute-nesting: 0
+  no-vendor-prefixes: 0
+  no-css-comments: 0
+  no-transition-all: 0
+  no-qualifying-elements:
+    - 1
+    - allow-element-with-attribute: true
+  class-name-format:
+    - 1
+    - convention: camelcase

assets/js/translator.js

@@ -133,8 +133,6 @@ if(modeEnabled('translation')) {
             synchronizeTextareaHeights();
         });
 
-        $(window).resize(synchronizeTextareaHeights);
-
         $('#originalText').blur(function () {
             persistChoices('translator', true);
         });

assets/js/util.js

@@ -11,6 +11,8 @@ var TEXTAREA_AUTO_RESIZE_MINIMUM_WIDTH = 768,
     BACK_TO_TOP_BUTTON_ACTIVATION_HEIGHT = 300,
     THRESHOLD_REQUEST_URL_LENGTH = 2000; // maintain 48 characters buffer for generated parameters
 
+var originalTextScrollHeight;
+
 // From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Polyfill
 /* eslint-disable */
 if (typeof Object.assign != 'function') {
@@ -162,6 +164,9 @@ $(document).ready(function () {
         return false;
     });
 
+    $('#originalText').mouseup(function () {
+        $('#originalText').css('overflow-y', $('#originalText').height() < originalTextScrollHeight ? 'scroll' : 'hidden');
+    });
 });
 
 if(config.PIWIK_SITEID && config.PIWIK_URL) {
@@ -278,7 +283,7 @@ function synchronizeTextareaHeights() {
         'overflow-y': 'hidden',
         'height': 'auto'
     });
-    var originalTextScrollHeight = $('#originalText')[0].scrollHeight;
+    originalTextScrollHeight = $('#originalText')[0].scrollHeight;
     $('#originalText').css('height', originalTextScrollHeight + 'px');
     $('#translatedText').css('height', originalTextScrollHeight + 'px');
 }

assets/strings/localisation-tools.py

@@ -16,6 +16,7 @@ def dumpJSON(f, data):
 def loadJSON(f):
     return json.loads(f.read(), object_pairs_hook=OrderedDict)
 
+
 if __name__ == '__main__':
     parser = argparse.ArgumentParser(description='Manipulate localisation files', formatter_class=argparse.RawTextHelpFormatter)
     parser.add_argument('actions', nargs='+', help="new/create: creates a new localisation file\n"

tools/localise-html.py

@@ -111,6 +111,7 @@ def run(html_path, json_path, out_path, conf_path, fallback_path):
     with open(out_path, 'w') as out:
         out.write("".join(parser.output))
 
+
 if __name__ == "__main__":
     argparser = argparse.ArgumentParser(description='Localise an HTML file using a json file from stdin')
     argparser.add_argument('template', help='HTML file to localise')