-
Couldn't load subscription status.
- Fork 62
Added Bitcoin to ISK endpoint #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pmm1
wants to merge
5
commits into
apis-is:master
Choose a base branch
from
pmm1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Bitcoin to ISK price | ||
|
|
||
| Source [Myntkaup.is](https://myntkaup.is) | ||
|
|
||
| - GET [/btc](https://apis.is/btc) | ||
|
|
||
| Current Bitcoin to ISK exchange rate. | ||
|
|
||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| const request = require('request') | ||
| const app = require('../../server') | ||
|
|
||
| // set cache time to 1 minute | ||
| const cacheTime = 60 | ||
|
|
||
| function queryGzipJson(url, callback) { | ||
| const headers = { | ||
| 'user-agent': 'apis.is', | ||
| } | ||
| request.get({ | ||
| headers, | ||
| url, | ||
| gzip: true, | ||
| json: true, | ||
| }, (error, response, data) => { | ||
| if (error || response.statusCode !== 200) { | ||
| callback(error, response, null) | ||
| } | ||
| callback(error, response, data) | ||
| }) | ||
| } | ||
|
|
||
| function queryRate(callback) { | ||
| queryGzipJson('https://myntkaup.is/api/assets/bitcoin', callback) | ||
| } | ||
|
|
||
| function standardErrorResponse(res) { | ||
| return res.status(500).json({ | ||
| error: 'myntkaup.is refuses to respond or give back data', | ||
| }) | ||
| } | ||
|
|
||
| app.get('/btc', (req, res) => { | ||
| queryRate((error, response, data) => { | ||
| if (error || response.statusCode !== 200) { | ||
| return standardErrorResponse(res) | ||
| } | ||
| return res.cache(cacheTime).json(data) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* eslint-disable no-bitwise */ | ||
| /* eslint-disable import/first */ | ||
| /* eslint-disable import/extensions */ | ||
| const request = require('request') | ||
| const helpers = require('../../../lib/test_helpers.js') | ||
|
|
||
| describe('btc', function () { | ||
| this.timeout(20000) | ||
pmm1 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| const rateTypes = { | ||
| id: String, | ||
| symbol: String, | ||
| currencySymbol: String, | ||
| rateUsd: Number, | ||
| rateIsk: Number, | ||
| rateIskFriendly: String | ||
| } | ||
| const statsFields = Object.keys(rateTypes) | ||
| it('should return object containing specific fields with correct types', (done) => { | ||
| const params = helpers.testRequestParams('/btc') | ||
| request.get(params, (err, res, body) => { | ||
pmm1 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if (err) throw err | ||
| let json | ||
| try { | ||
| json = JSON.parse(body) | ||
| } catch (e) { | ||
| throw e | ||
| } | ||
| helpers.assertPresenceOfFields(statsFields, [json]) | ||
| helpers.assertTypesOfFields(rateTypes, [json]) | ||
| done() | ||
| }) | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.