Remove use of uuid package #805
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto.randomUUIDis supported since Node.js 14.17.0.: https://nodejs.org/api/crypto.html#cryptorandomuuidoptionsThe CI pipeline suggests that this library supports Node from 14 onwards (even though v18 will run out of support tomorrow):
dockerode/.github/workflows/main.yml
Line 14 in 3f68f9b
This might be a breaking change if someone uses Node.js < 14.17. CI pulls in 14.21.3 as it is specified to use
14.x.The package.json has
"engine": "node > 8", so I'm not entirely sure which Node.js versions are officially supported. If this project aims to support only the currently supported Node.js versions, this PR is not a breaking change.The motivation for this change is to reduce download size in general. Dockerode is downloaded
1265386times a week, so about 68,330,844 times a year. [email protected] is29328 bytes. So this dependency causes traffic of about 1866 GiB per year (about 1.8TB).