Skip to content

Conversation

@martinnabhan
Copy link
Collaborator

@martinnabhan martinnabhan commented Oct 28, 2025

Fixes #287

@martinnabhan martinnabhan self-assigned this Oct 28, 2025
@martinnabhan martinnabhan requested a review from a team as a code owner October 28, 2025 04:13
@martinnabhan martinnabhan requested a review from Copilot October 28, 2025 04:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Next.js version 16 to the Apollo Server integration library. The changes consolidate API resolver imports across Next.js versions 13-16, update package dependencies, and streamline CI/CD workflows.

Key changes:

  • Unified API resolver imports for Next.js versions 13 through 16 to use the same import path
  • Added Next.js 16 as a peer dependency and included it in the testing matrix
  • Simplified linting and formatting commands to check entire codebase instead of just changed files

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/tests/integration.test.ts Consolidated API resolver imports for Next.js 13-16 into a single case statement and removed deprecated dev parameter
package.json Added next16 alias, updated peer dependencies to include ^16.0.0, added test:next16 script, and simplified linting commands
renovate.json5 Added version constraint configuration for next16 package
.github/workflows/check.yml Removed fetch-depth parameter from checkout action
.changeset/modern-wombats-rhyme.md Added changeset entry documenting Next.js 16 support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

},
"check:eslint": {
"command": "eslint --ignore-path .prettierignore $(git diff --diff-filter d --name-only HEAD~1 | grep -E '\\.(js|ts)$' | xargs)"
"command": "eslint --ignore-path .prettierignore ."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since eslint and prettier finish super quick I changed this so we check every file instead of just the changed files.

{
matchPackageNames: ['next16'],
allowedVersions: '16.x',
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want next16 to stay on v16 so we have to pin it.

({ apiResolver } = await import('next15/dist/server/api-utils/node/api-resolver'));
break;
case '16':
({ apiResolver } = await import('next16/dist/server/api-utils/node/api-resolver'));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily there doesn't seem to be any internal changes.

@martinnabhan martinnabhan merged commit 87f9e0f into main Oct 28, 2025
2 checks passed
@martinnabhan martinnabhan deleted the next-16 branch October 28, 2025 04:20
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Next js 16 update

2 participants