-
Notifications
You must be signed in to change notification settings - Fork 75
Fixing supply systems graphics #3927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
acb4600
Fixing supply systems graphics
MatNif 601e4e6
fixing the pickle error
ShiZhongming 04bc146
Remove unused variable
reyery 6506053
Refactor locator handling in SupplySystemGraphInfo
reyery f0e3b2e
Remove Dash app and automate supply system plot generation
reyery ee9a534
Add combined supply system plot with dropdown menus
reyery 6311e52
Use locator instead of path joins
reyery 6b8a579
Refactor main to accept config parameter
reyery 957bc25
Add plot-supply-system script to scripts.yml
reyery bdab236
Add supply system visualization script
reyery 933a284
Remove saving of combined figure to HTML file
reyery adc7c76
Add error handling for missing component icons
reyery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+16.7 KB
cea/plots/optimization_new/images/component_img/unknownComponent_icon.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import cea.config | ||
| from cea.plots.optimization_new.b_supply_system import main as supply_system_main | ||
|
|
||
| __author__ = "Mathias Niffeler" | ||
| __copyright__ = "Copyright 2025, Architecture and Building Systems - ETH Zurich" | ||
| __credits__ = ["Mathias Niffeler"] | ||
| __license__ = "MIT" | ||
| __version__ = "0.1" | ||
| __maintainer__ = "Reynold Mok" | ||
| __email__ = "[email protected]" | ||
| __status__ = "Production" | ||
|
|
||
|
|
||
| def main(config): | ||
| fig = supply_system_main(config) | ||
|
|
||
| return fig.to_html() if fig is not None else "" | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| main(cea.config.Configuration()) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.