-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add managed identity support to app insights serilog sink (⌛ wait until analysis v4 is complete) #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for arcus-observability canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
+ Coverage 86.96% 87.90% +0.93%
==========================================
Files 70 69 -1
Lines 2593 2604 +11
Branches 151 149 -2
==========================================
+ Hits 2255 2289 +34
+ Misses 294 268 -26
- Partials 44 47 +3 ☔ View full report in Codecov by Sentry. |
/azp run CI - Arcus.Observability |
Azure Pipelines successfully started running 1 pipeline(s). |
Is this feature still wanted after being stale for 2 years? Otherwise I could pick this up 😄 |
First some slimmed-down exercise needs to happen on the Arcus repo's before we can start with new functionality, I would say. |
Sure. How can I help? I presume you'd first want to do an analysis? |
Yes, working on that here: #578 |
I can also help out in any other repo. |
We'll keep that in mind, just now a lot of analyzing needs to happen before we can start creating chore tasks for them. After that has been done, we can definitely some tasks for you! In other Arcus repo's the |
Adds managed identity support to the Serilog Application Insights sink that lets you provide a client ID together with the ingestion connection string towards Azure Application Insights.
Closes #541