Skip to content

Conversation

stijnmoreels
Copy link
Member

Adds managed identity support to the Serilog Application Insights sink that lets you provide a client ID together with the ingestion connection string towards Azure Application Insights.

Closes #541

@stijnmoreels stijnmoreels self-assigned this Oct 27, 2023
@netlify
Copy link

netlify bot commented Oct 27, 2023

Deploy Preview for arcus-observability canceled.

Name Link
🔨 Latest commit 35f91eb
🔍 Latest deploy log https://app.netlify.com/sites/arcus-observability/deploys/655c621f69d2b700081fd4aa

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f663587) 86.96% compared to head (35f91eb) 87.90%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ts/Extensions/LoggerSinkConfigurationExtensions.cs 97.82% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   86.96%   87.90%   +0.93%     
==========================================
  Files          70       69       -1     
  Lines        2593     2604      +11     
  Branches      151      149       -2     
==========================================
+ Hits         2255     2289      +34     
+ Misses        294      268      -26     
- Partials       44       47       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnmoreels
Copy link
Member Author

/azp run CI - Arcus.Observability

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joachimgoris
Copy link

Is this feature still wanted after being stale for 2 years? Otherwise I could pick this up 😄

@stijnmoreels
Copy link
Member Author

Is this feature still wanted after being stale for 2 years? Otherwise I could pick this up 😄

First some slimmed-down exercise needs to happen on the Arcus repo's before we can start with new functionality, I would say.

@joachimgoris
Copy link

Sure. How can I help? I presume you'd first want to do an analysis?

@stijnmoreels
Copy link
Member Author

Sure. How can I help? I presume you'd first want to do an analysis?

Yes, working on that here: #578
But first other repo's are prioritized, I believe.

@joachimgoris
Copy link

I can also help out in any other repo.

@stijnmoreels
Copy link
Member Author

stijnmoreels commented May 23, 2025

I can also help out in any other repo.

We'll keep that in mind, just now a lot of analyzing needs to happen before we can start creating chore tasks for them. After that has been done, we can definitely some tasks for you!

In other Arcus repo's the good-first-issue label is a good indicator; otherwise, there's a lot of work in adding/defining tasks for the Arcus management team to be done. But we'll it in mind. Thx a lot for the enthusiasm! 💗

@stijnmoreels stijnmoreels changed the title feat: add managed identity support to app insights serilog sink feat: add managed identity support to app insights serilog sink (⌛ wait until analysis v4 is complete) May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure AD Authentication In the ApplicationInsights Sink
2 participants