chore(deprecate): application name/version enrichment for being too project-specific #605
Conversation
stijnmoreels
added
the
enrichers
✅ Deploy Preview for arcus-observability canceled.
|
| /// <seealso cref="IAppVersion"/> | ||
| #pragma warning disable S1133 | ||
| [Obsolete("Will be removed in v4.0 as application versioning enrichment is too project-specific")] | ||
| #pragma warning restore S1133 |
There was a problem hiding this comment.
I don't think we should do that. IMHO, this is really valuable. (And that is for all deprecations in this PR)
There was a problem hiding this comment.
Maybe in the older Serilog setup, but with OpenTelemetry these 'resource information' is set differently and on different places, as well. Think their way of working is rather clean and interfaces like these would maybe overcomplicate it.
There was a problem hiding this comment.
What would be the approach then, as this is really valuable information. AFAIK, this is being used in multiple customer-projects.
There was a problem hiding this comment.
Think people we go directly to this page: (https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-configuration?tabs=aspnetcore#set-the-cloud-role-name-and-the-cloud-role-instance) to figure out how to set the application name instead of Arcus docs.
There was a problem hiding this comment.
That is afaik only valid when you use opentelemetry ?
There was a problem hiding this comment.
Yes, and since this should be on all projects according to CTO, it seems like the way to go instead of our own.
2 participants
As mentioned in Arcus sessions and documented at #587 , the application name/versioning enrichment is too project-specific and a bit outside the scope of what Arcus should provide.
This PR deprecates this application name/versioning functionality.