-
Notifications
You must be signed in to change notification settings - Fork 12
docs(v3): rework feature docs for v3 #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
stijnmoreels
wants to merge
17
commits into
arcus-azure:main
Choose a base branch
from
stijnmoreels:docs/rework-feat-docs-for-v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs(v3): rework feature docs for v3 #485
stijnmoreels
wants to merge
17
commits into
arcus-azure:main
from
stijnmoreels:docs/rework-feat-docs-for-v3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for arcus-security canceled.
|
fgheysels
reviewed
Oct 9, 2025
| } | ||
| ``` | ||
|
|
||
| Make sure to use the factory methods on `SecretResult` correctly based on the external situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"use correctly" or "correctly use" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'use correctly' seems to be more everyday.
Co-authored-by: Frederik Gheysels <[email protected]>
Co-authored-by: Frederik Gheysels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
All issues related to documentation
management
All issues related to management of the project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure, rewrite and simplify (preview) feature documentation in preparation for the v3 release. It also includes the local search (instead of the unstable Algoria) and uses PowerShell as code language to show installation commands.
Furthermore, the 'common' functionality is located at the secret store index page and an introduction/getting-started page is added to guide consumers more into the Arcus Security space.
(Later, a dropdown menu with the available Arcus spaces might be beneficial as well.)