Skip to content

Convert std::string to idiomatic Arduino #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

Convert std::string to idiomatic Arduino #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/NiclaSenseEnv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#include "NiclaSenseEnv.h"
#include "registers.h"
#include <string>
#include <array>

// Define baud rate values corresponding to indices 0 - 7
const int baudRateMap[] = {1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200};
Expand Down Expand Up @@ -100,11 +98,11 @@ String NiclaSenseEnv::serialNumber() {
readFromRegister<uint8_t, size>(SERIAL_NUMBER_REGISTER_INFO, serialNumber);

// Construct serial number by concatenating each of the 6 bytes as a string
std::string serialNumberString;
String serialNumberString;
for (auto byte : serialNumber) {
serialNumberString += std::to_string(byte);
serialNumberString += String(byte, DEC);
}
return String(serialNumberString.c_str());
return serialNumberString;
}

int NiclaSenseEnv::productID() {
Expand Down
Loading