Skip to content

Conversation

gorillagripcore
Copy link
Contributor

No description provided.

Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is something that only advanced users should attempt, without expectation of support from Arduino for the 3rd party themes, we made a conscious decision that this information should only be published in the advanced usage documentation in the GitHub repository:

https://github.com/arduino/arduino-ide/blob/main/docs/advanced-usage.md#3rd-party-themes

@gorillagripcore
Copy link
Contributor Author

Since this is something that only advanced users should attempt, without expectation of support from Arduino for the 3rd party themes, we made a conscious decision that this information should only be published in the advanced usage documentation in the GitHub repository:

https://github.com/arduino/arduino-ide/blob/main/docs/advanced-usage.md#3rd-party-themes

I mean we already have this: https://support.arduino.cc/hc/en-us/articles/4408893497362-Use-a-custom-theme-for-Arduino-IDE-1

Also, how is it "something that only advanced users should attempt"? :)

@gorillagripcore gorillagripcore changed the title Use a custom theme for Arduino IDE 2 Use a custom theme for Arduino IDE 2 [HC-1270] Oct 2, 2024
@per1234
Copy link
Collaborator

per1234 commented Oct 2, 2024

we already have this

Yes, but the custom themes for Arduino IDE 1.x are designed specifically for Arduino IDE 1.x. So there is a reasonable level of confidence that they will work correctly.

how is it "something that only advanced users should attempt"?

Because these themes were created for VS Code, not for Arduino IDE. The Arduino IDE theme system is a bit convoluted and this means it is a gamble whether or not there will be sufficient contrast between foreground and background colors (even though the theme is perfect when used with VS Code). In some cases, this will make UI elements invisible.

We actually already have this problem with the themes that are built into the Eclipse Theia framework and thus are included in the IDE installation. This caused us to receive many bug reports and support requests from users of those themes until the Arduino IDE developers finally managed to find a way to remove those options from the IDE preferences to stop people from using them.

@gorillagripcore
Copy link
Contributor Author

@per1234 You can literally just change back to a default theme if it doesn't work. it's not that deep.

I can put a warning in the article if you want :))

@per1234
Copy link
Collaborator

per1234 commented Oct 2, 2024

The average user won't understand that the apparently missing UI element is caused by the theme. They will think it is caused by a bug in the IDE. And so it becomes a burden on those of us who provide support and maintainership for the Arduino IDE 2.x. We are already stretched far too thin so we don't need any more.

I'm sorry but this was already decided 1.5 years ago. It is not worth discussing any further.

@per1234 per1234 closed this Oct 2, 2024
@seaxwi
Copy link
Collaborator

seaxwi commented Oct 2, 2024

Hi @per1234

Since this is something that only advanced users should attempt, without expectation of support from Arduino for the 3rd party themes, we made a conscious decision that this information should only be published in the advanced usage documentation in the GitHub repository

I was not aware of this decision, although given the points you raised I can understand why it was made.

we made a conscious decision that this information should only be published in the advanced usage documentation in the GitHub repository

Does this decision also mean we should avoid linking to the information from more accessible documentation sources like the Help Center? For example, linking to it from the existing custom theme installation article, while mentioning the limitations of using themes designed for VS Code and that it is not a supported feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants