-
-
Notifications
You must be signed in to change notification settings - Fork 26
[AE-28][AE-51] Merged improvements to Arduino_BHY2 and Arduino_BHY2Host #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory usage change @ 4d04d2a
Click for full report table
Click for full report CSV
|
Memory usage change @ 691c7c6
Click for full report table
Click for full report CSV
|
Memory usage change @ dd87249
Click for full report table
Click for full report CSV
|
Memory usage change @ 166cd08
Click for full report table
Click for full report CSV
|
Memory usage change @ 720b8e9
Click for full report table
Click for full report CSV
|
Inline documentation has been streamlined to be more useful for the end user. Changes include:
|
Memory usage change @ d4f8918
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some (not all) comments by @sebromero in #86
Note: Some fixes are not possible in the current state of the library. Specifically, different SensorIDs influence the behaviour of functions differently. See for example: https://github.com/arduino/nicla-sense-me-fw/pull/65/files#diff-dc234d4525482649e299028b11f8764c62f2c41e8b8cbfdb2411bc7bbe369b3eR38
Reccomendation:
Pull request type