Skip to content

Conversation

llavaud
Copy link
Contributor

@llavaud llavaud commented Sep 29, 2025

What does this PR do / why we need it:

  • Update the kubernetes/argocd/principal kustomization patch to add update on argoproj.io.Applications for the server's clusterrole

Which issue(s) this PR fixes:

If i try to sync an app through the UI, I got the following error:

Unable to sync: error setting app operation: error updating application "test-app": applications.argoproj.io "test-app" is forbidden: User "system:serviceaccount:argocd:argocd-server" cannot update resource "applications" in API group "argoproj.io" in the namespace "my-first-agent"

It seems we need to allow the server to update Application's status

How to test changes / Special notes to the reviewer:

Checklist

  • Documentation update is required by this PR (and has been updated) OR no documentation update is required.

@llavaud llavaud force-pushed the fix-principal-server-rbac branch from 260f063 to 298d837 Compare September 29, 2025 07:36
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.62%. Comparing base (c9f93b7) to head (f19019a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   45.62%   45.62%           
=======================================
  Files          90       90           
  Lines       12021    12021           
=======================================
  Hits         5485     5485           
  Misses       6091     6091           
  Partials      445      445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jannfis
Copy link
Collaborator

jannfis commented Oct 2, 2025

It's weird, I cannot reproduce that. How did you install Argo CD?

@llavaud
Copy link
Contributor Author

llavaud commented Oct 3, 2025

It's weird, I cannot reproduce that. How did you install Argo CD?

I strictly followed the getting started guide 🤷‍♂️

Just after the application creation, If I go to the console and try to sync the app I have the following error message.

It seems someone else ran into this issue: https://cloud-native.slack.com/archives/C07L5SX6A9J/p1759003332931939?thread_ts=1758727098.927749&cid=C07L5SX6A9J

Screenshot 2025-10-03 at 09 04 50

Copy link
Collaborator

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jannfis jannfis merged commit f6e8e9b into argoproj-labs:main Oct 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants