Skip to content

Conversation

@chengfang
Copy link
Collaborator

@chengfang chengfang commented Nov 12, 2025

Summary by CodeRabbit

  • Chores
    • Upgraded Go toolchain from 1.24.6 to 1.25.0 and updated numerous core dependencies including Kubernetes APIs (v0.34.0), Prometheus, OpenTelemetry, gRPC gateway, Azure SDKs, JWT libraries, YAML processors, and auxiliary utilities across the project ecosystem.
    • Refactored internal gRPC client creation pathway.

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request updates the gRPC client creation method in ask_pass.go from BlockingDial to BlockingNewClient while modernizing dependencies across the project, including Go toolchain to 1.25.0 and multiple libraries such as Kubernetes, Prometheus, OpenTelemetry, and gRPC components.

Changes

Cohort / File(s) Summary
gRPC Client Creation
cmd/ask_pass.go
Replaces grpc_util.BlockingDial with grpc_util.BlockingNewClient in NewAskPassCommand for client initialization; all other logic remains unchanged.
Dependency Updates
go.mod
Bumps Go toolchain to 1.25.0; updates argo-cd, Kubernetes (v0.34.0), Prometheus, OpenTelemetry, gRPC-gateway, Azure SDKs, Casbin, and numerous other indirect dependencies to align with newer versions. No public API changes.

Pre-merge checks

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title focuses on argo-cd version bump, but the changeset includes substantial Go toolchain, Kubernetes, and numerous dependency updates beyond just argo-cd. Update title to reflect broader scope: 'chore(deps): update dependencies including argo-cd v3.2.0, Go 1.25, Kubernetes v0.34.0' or similar to accurately represent all major changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Comment @coderabbitai help to get the list of available commands and usage tips.

@chengfang chengfang marked this pull request as draft November 12, 2025 16:04
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.85%. Comparing base (fc7b082) to head (e920389).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
+ Coverage   70.69%   79.85%   +9.15%     
==========================================
  Files          49       21      -28     
  Lines        4522     1544    -2978     
==========================================
- Hits         3197     1233    -1964     
+ Misses       1128      255     -873     
+ Partials      197       56     -141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chengfang chengfang added the hold label Nov 12, 2025
@chengfang
Copy link
Collaborator Author

Mark it as hold for now.

The errors in ci: "invalid array length -delta * delta" may be fixed once #1317 is merged. Will revisit this PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants