Skip to content

feat: improve StatefulSet immutable field error messages #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

feat: improve StatefulSet immutable field error messages #654

wants to merge 11 commits into from

Conversation

aali309
Copy link

@aali309 aali309 commented Dec 17, 2024 •
edited
Loading

Fixes: 20899
Depends on: 21209

Before:
Screenshot 2024-12-13 at 8 30 35 PM

After:
Screenshot 2025-02-13 at 4 33 35 PM

@aali309 aali309 changed the title feat: Enhance sync error message to report the actual field(s) that violated forbidden updates feat: improve StatefulSet immutable field error messages Dec 17, 2024
@aali309 aali309 mentioned this pull request Dec 17, 2024
Merged
14 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.35211% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.03%. Comparing base (8849c3f) to head (88a977f).
⚠️ Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
pkg/sync/sync_context.go 75.35% 24 Missing and 11 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   54.26%   48.03%   -6.23%     
==========================================
  Files          64       64              
  Lines        6164     6730     +566     
==========================================
- Hits         3345     3233     -112     
- Misses       2549     3229     +680     
+ Partials      270      268       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aali309 aali309 force-pushed the reportTheFieldThatViolated branch from 0ede6a9 to ffd6fbb Compare December 18, 2024 19:29
@aali309 aali309 marked this pull request as ready for review December 18, 2024 19:33
@aali309 aali309 requested a review from a team as a code owner December 18, 2024 19:33
@aali309 aali309 force-pushed the reportTheFieldThatViolated branch 3 times, most recently from ffd6fbb to 1751d55 Compare December 19, 2024 20:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aali309 aali309 force-pushed the reportTheFieldThatViolated branch from 1751d55 to 8b51f31 Compare February 10, 2025 21:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aali309
Copy link
Author

aali309 commented Mar 11, 2025

@pasha-codefresh, can I get a review on this as well please. This is part of argoproj/argo-cd#21209

@aali309 aali309 requested a review from pasha-codefresh June 26, 2025 15:28
@aali309 aali309 force-pushed the reportTheFieldThatViolated branch from 0078dc3 to 488b379 Compare June 26, 2025 17:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aali309
Copy link
Author

aali309 commented Jun 26, 2025

codecov failure is because of the rebase

@aali309
This is a combination of 8 commits.
317527d 
feat: enhance StatefulSet immutable field error message to show specific field changes

Signed-off-by: Atif Ali <[email protected]>

formatting && added tests

Signed-off-by: Atif Ali <[email protected]>
@aali309
reduce sonarcloud issues
9ed0ce7 
Signed-off-by: Atif Ali <[email protected]>
@aali309
resolve linter issues
f32f3ad 
Signed-off-by: Atif Ali <[email protected]>
@aali309
refactor applyObject method to reduce complexity
cfb403e 
Signed-off-by: Atif Ali <[email protected]>
@aali309
refactor formatValue method to reduce complexity
c067393 
Signed-off-by: Atif Ali <[email protected]>
@aali309
special formatting for volumeClaimTemplates changes
842e205 
Signed-off-by: Atif Ali <[email protected]>
@aali309
fix test failures
cadfa1c 
Signed-off-by: Atif Ali <[email protected]>
@aali309
fix test failures2
9260828 
Signed-off-by: Atif Ali <[email protected]>
@aali309 aali309 force-pushed the reportTheFieldThatViolated branch from c2d88a2 to 9260828 Compare September 11, 2025 01:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
11.9% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh Awaiting requested review from pasha-codefresh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report the field that violated the updates to fields are forbidden constraint
1 participant
@aali309