feat: add missing fields to values #175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify serviceAccount to be able to use externally created SA Signed-off-by: David Sabatie <[email protected]>
|
Hello @arttor, can you review this PR please ? We need it 🙏 |
arttor
reviewed
Oct 23, 2025
Signed-off-by: David Sabatie <[email protected]>
|
@arttor Thank you for the review, I fixed your point. I also have also backported the automount field from a blank helm chart generated with the latest helm.sh release (helm create ...). |
|
@Greendor1234 there is a lint errors on CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify serviceAccount to be able to use externally created SA.
It also add nodeSelector, tolerations and topologySpreadContraints fields to values.yaml (with empty values by default).
closes #174